Skip to content

add destionation configs sub fields#17211

Merged
roaks3 merged 2 commits into
GoogleCloudPlatform:mainfrom
kefang2:update-destionation-configs
Apr 22, 2026
Merged

add destionation configs sub fields#17211
roaks3 merged 2 commits into
GoogleCloudPlatform:mainfrom
kefang2:update-destionation-configs

Conversation

@kefang2
Copy link
Copy Markdown
Contributor

@kefang2 kefang2 commented Apr 21, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

discoveryengine: added `destionation_configs.destionations.port` and `destionation_configs.params` fields to `google_discovery_engine_data_connector ` resource

@github-actions github-actions Bot requested a review from roaks3 April 21, 2026 00:25
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 97 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 97 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 31 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_data_connector (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_data_connector" "primary" {
  destination_configs {
    destinations {
      port = # value needed
    }
    params = # value needed
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 40
Passed tests: 34
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineDataConnector_discoveryengineDataconnectorJiraWithActionsExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 105 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 105 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 31 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineDataConnector_discoveryengineDataconnectorJiraWithActionsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 40
Passed tests: 35
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@roaks3 roaks3 added this pull request to the merge queue Apr 22, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 4e578c7 Apr 22, 2026
24 of 25 checks passed
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants