Fixed type mismatch in `google_ces_app` variable default value by apsureda · Pull Request #17221 · GoogleCloudPlatform/magic-modules

apsureda · 2026-04-21T18:19:05Z

Release Note Template for Downstream PRs (will be copied)

Fixes hashicorp/terraform-provider-google#26627

ces: fixed type mismatch in `google_ces_app` variable default value

… 26627)

github-actions · 2026-04-21T18:19:33Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-04-21T19:02:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 28 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 3 files changed, 28 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))

modular-magician · 2026-04-21T19:05:47Z

Tests analytics

Total tests: 51
Passed tests: 46
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages

ces

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCESApp_cesAppAmbientSoundGcsUriExample

TestAccCESApp_cesAppBasicExample

TestAccCESApp_update

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update

Get to know how VCR tests work

modular-magician · 2026-04-21T19:07:01Z

🟢 Tests passed during RECORDING mode:
TestAccCESApp_cesAppAmbientSoundGcsUriExample [Debug log]
TestAccCESApp_cesAppBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccCESApp_update [Error message] [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample [Error message] [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-21T20:00:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 29 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 29 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))

modular-magician · 2026-04-21T20:04:43Z

Tests analytics

Total tests: 51
Passed tests: 48
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

ces

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCESApp_update

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update

Get to know how VCR tests work

modular-magician · 2026-04-21T20:05:30Z

🔴 Tests failed during RECORDING mode:
TestAccCESApp_update [Error message] [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample [Error message] [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…s` is not supported in the app.

…ymore?) API: https://docs.cloud.google.com/customer-engagement-ai/conversational-agents/ps/reference/rest/v1/projects.locations.apps.tools#Tool.DataStoreTool Failing test case: resource_ces_tool_generated_test.go:216: Step 1/3 error: After applying this test step, the non-refresh plan was not empty. ... ~ data_store_tool { ~ max_results = 0 -> 5 name = "example-tool"

modular-magician · 2026-04-22T18:20:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 30 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 6 files changed, 30 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 deletion(-))

modular-magician · 2026-04-22T18:25:04Z

Tests analytics

Total tests: 51
Passed tests: 48
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

ces

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCESApp_update

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update

Get to know how VCR tests work

modular-magician · 2026-04-22T18:26:13Z

🟢 Tests passed during RECORDING mode:
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccCESApp_update [Error message] [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…the API now requires a secret version path: Error 400: Passphrase must be a Secret Manager resource name.

…e API and now it results on a drift after each terraform apply: ces_tool_test.go:295: Step 1/4 error: After applying this test step, the non-refresh plan was not empty. ... ~ data_store_tool { ~ max_results = 0 -> 5 name = "example-tool"

modular-magician · 2026-04-22T19:06:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 29 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 8 files changed, 29 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 deletions(-))

modular-magician · 2026-04-22T19:10:41Z

Tests analytics

Total tests: 51
Passed tests: 48
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

ces

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCESApp_cesAppBasicExample

TestAccCESApp_update

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update

Get to know how VCR tests work

modular-magician · 2026-04-22T19:12:01Z

🟢 Tests passed during RECORDING mode:
TestAccCESApp_cesAppBasicExample [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccCESApp_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-22T21:19:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 32 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 9 files changed, 32 insertions(+), 21 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 deletions(-))

modular-magician · 2026-04-22T21:24:00Z

Tests analytics

Total tests: 51
Passed tests: 48
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

ces

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCESApp_update

TestAccCESGuardrail_cesGuardrailGenerativeAnswerLlmPromptSecurityExample_update

TestAccCESGuardrail_cesGuardrailLlmPolicyExample_update

Get to know how VCR tests work

modular-magician · 2026-04-22T21:25:22Z

🟢 Tests passed during RECORDING mode:
TestAccCESGuardrail_cesGuardrailGenerativeAnswerLlmPromptSecurityExample_update [Debug log]
TestAccCESGuardrail_cesGuardrailLlmPolicyExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccCESApp_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Successfully ran all tests locally.

modular-magician · 2026-04-23T15:47:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 68 insertions(+), 57 deletions(-))
google-beta provider: Diff ( 17 files changed, 68 insertions(+), 57 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 12 insertions(+), 14 deletions(-))

modular-magician · 2026-04-23T15:50:48Z

Tests analytics

Total tests: 51
Passed tests: 36
Skipped tests: 0
Affected tests: 15

Click here to see the affected service packages

ces

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCESAgent_cesAgentBasicExample

TestAccCESAgent_cesAgentBasicExample_update

TestAccCESAgent_cesAgentRemoteDialogflowAgentExample

TestAccCESAgent_cesAgentRemoteDialogflowAgentInterruptionExample

TestAccCESApp_cesAppAmbientSoundGcsUriExample

TestAccCESApp_cesAppBasicExample

TestAccCESApp_update

TestAccCESExample_cesExampleBasicExample

TestAccCESExample_update

TestAccCESGuardrail_cesGuardrailGenerativeAnswerLlmPromptSecurityExample

TestAccCESGuardrail_cesGuardrailGenerativeAnswerLlmPromptSecurityExample_update

TestAccCESGuardrail_cesGuardrailLlmPolicyExample

TestAccCESGuardrail_cesGuardrailLlmPolicyExample_update

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample

TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update

Get to know how VCR tests work

modular-magician · 2026-04-23T15:52:59Z

🟢 Tests passed during RECORDING mode:
TestAccCESAgent_cesAgentBasicExample [Debug log]
TestAccCESAgent_cesAgentBasicExample_update [Debug log]
TestAccCESAgent_cesAgentRemoteDialogflowAgentExample [Debug log]
TestAccCESAgent_cesAgentRemoteDialogflowAgentInterruptionExample [Debug log]
TestAccCESApp_cesAppAmbientSoundGcsUriExample [Debug log]
TestAccCESApp_cesAppBasicExample [Debug log]
TestAccCESApp_update [Debug log]
TestAccCESExample_cesExampleBasicExample [Debug log]
TestAccCESExample_update [Debug log]
TestAccCESGuardrail_cesGuardrailGenerativeAnswerLlmPromptSecurityExample [Debug log]
TestAccCESGuardrail_cesGuardrailGenerativeAnswerLlmPromptSecurityExample_update [Debug log]
TestAccCESGuardrail_cesGuardrailLlmPolicyExample [Debug log]
TestAccCESGuardrail_cesGuardrailLlmPolicyExample_update [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

hao-nan-li

Do you plan to add the deprecation message in PR? If not opening another PR is ok

…he field has been removed from the CES API.

…es into ces-app-var-default

apsureda · 2026-04-23T20:14:01Z

Do you plan to add the deprecation message in PR? If not opening another PR is ok

Since I finally only added the deprecation message, with no changes in behavior, I think it's OK to simply add it to this PR.
I initially thought to make it ignore that field, but that would be confusing for those who were already using that field and expect it to have some effect. It's better to let it trigger a diff in the tf plan. The deprecation message will tell the users to remove that field.

modular-magician · 2026-04-23T20:30:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 74 insertions(+), 60 deletions(-))
google-beta provider: Diff ( 18 files changed, 74 insertions(+), 60 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 12 insertions(+), 14 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_ces_tool (18 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_ces_tool" "primary" {
  data_store_tool {
    max_results = # value needed
  }
}

modular-magician · 2026-04-23T20:35:00Z

Tests analytics

Total tests: 51
Passed tests: 51
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

ces

🟢 All tests passed!

View the build log

…eCloudPlatform#17221)

apsureda added 2 commits April 21, 2026 17:40

Fix type mismatch on ces_app declared variables default values (issue…

beefbf3

… 26627)

Added documentation change

52be92f

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 21, 2026

github-actions Bot requested a review from hao-nan-li April 21, 2026 18:19

modular-magician added service/ces and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 21, 2026

Fixing CES basic test

ce71bcd

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 21, 2026

apsureda added 2 commits April 22, 2026 08:07

Fix test case error: Language code 'es-ES' in `synthesizeSpeechConfig…

36c4154

…s` is not supported in the app.

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 22, 2026

apsureda added 2 commits April 22, 2026 18:48

Removing the passphrase from the examples, since it is optional, and …

0061969

…the API now requires a secret version path: Error 400: Passphrase must be a Secret Manager resource name.

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 22, 2026

Acceptance tests fix: updated model version across all test cases.

4bd91c7

Successfully ran all tests locally.

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 23, 2026

Merge branch 'main' into ces-app-var-default

05abd1d

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 23, 2026

hao-nan-li reviewed Apr 23, 2026

View reviewed changes

apsureda added 2 commits April 23, 2026 20:05

Added deprecation message on max_results fiels in data_store tools. T…

16680f0

…he field has been removed from the CES API.

Merge branch 'ces-app-var-default' of github.com:apsureda/magic-modul…

0fa5c93

…es into ces-app-var-default

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 23, 2026

github-actions Bot requested a review from hao-nan-li April 23, 2026 20:10

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 23, 2026

hao-nan-li approved these changes Apr 23, 2026

View reviewed changes

hao-nan-li added this pull request to the merge queue Apr 23, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 4985c8f Apr 23, 2026
27 checks passed

ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026

Fixed type mismatch in google_ces_app variable default value (Googl…

71a2940

…eCloudPlatform#17221)

Conversation

apsureda commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

modular-magician commented Apr 21, 2026

Diff report

Uh oh!

modular-magician commented Apr 21, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 21, 2026

Uh oh!

modular-magician commented Apr 21, 2026

Diff report

Uh oh!

modular-magician commented Apr 21, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 21, 2026

Uh oh!

modular-magician commented Apr 22, 2026

Diff report

Uh oh!

modular-magician commented Apr 22, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 22, 2026

Uh oh!

modular-magician commented Apr 22, 2026

Diff report

Uh oh!

modular-magician commented Apr 22, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 22, 2026

Uh oh!

modular-magician commented Apr 22, 2026

Diff report

Uh oh!

modular-magician commented Apr 22, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 22, 2026

Uh oh!

modular-magician commented Apr 23, 2026

Diff report

Uh oh!

modular-magician commented Apr 23, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 23, 2026

Uh oh!

hao-nan-li left a comment

Choose a reason for hiding this comment

Uh oh!

apsureda commented Apr 23, 2026

Uh oh!

modular-magician commented Apr 23, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Apr 23, 2026

Tests analytics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants