Skip to content

feat: Add support for the emptyDir DISK medium for cloudrunv2 workerpool#17225

Merged
roaks3 merged 1 commit into
GoogleCloudPlatform:mainfrom
jindaln:ephemeral_disk_worker_pool
Apr 22, 2026
Merged

feat: Add support for the emptyDir DISK medium for cloudrunv2 workerpool#17225
roaks3 merged 1 commit into
GoogleCloudPlatform:mainfrom
jindaln:ephemeral_disk_worker_pool

Conversation

@jindaln
Copy link
Copy Markdown
Contributor

@jindaln jindaln commented Apr 21, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudrunv2: added `DISK` fields to `google_cloud_run_v2_worker_pool` resource

Fixed: b/505090254

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 21, 2026
@github-actions github-actions Bot requested a review from roaks3 April 21, 2026 21:00
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/run and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 22, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 109 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 109 insertions(+), 3 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 129 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 89
Passed tests: 79
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolEmptydirDiskExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolEmptydirDiskExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants