Skip to content

Fixed priority documentation for google_compute_router_route_policy#17229

Merged
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom
SamuPert:samupert/fix-priority-compute_router_route_policy
Apr 22, 2026
Merged

Fixed priority documentation for google_compute_router_route_policy#17229
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom
SamuPert:samupert/fix-priority-compute_router_route_policy

Conversation

@SamuPert
Copy link
Copy Markdown
Contributor

@SamuPert SamuPert commented Apr 21, 2026

API Documentation: https://docs.cloud.google.com/compute/docs/reference/rest/v1/routers/updateRoutePolicy#:~:text=The%20evaluation%20priority%20for%20this%20term%2C%20which%20must%20be%20between%200%20(inclusive)%20and%202%5E31%20(exclusive)%2C%20and%20unique%20within%20the%20list.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed max priority value in documentation in `google_compute_router_route_policy`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 21, 2026
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from zli82016 April 21, 2026 23:42
@modular-magician modular-magician added service/compute-router and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 22, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1417
Passed tests: 1311
Skipped tests: 91
Affected tests: 15

Click here to see the affected service packages
  • compute

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample
  • TestAccComputeFirewallPolicyRule_firewallPolicyRuleSecureTagsExample
  • TestAccComputeFirewallPolicyRule_secureTags
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicyWithRules_update
  • TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample
  • TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update
  • TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample
  • TestAccComputeNetworkFirewallPolicyRule_secureTags
  • TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeNetworkFirewallPolicyWithRules_update
  • TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample
  • TestAccComputeRegionNetworkFirewallPolicyRule_secureTags
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeFirewallPolicyRule_firewallPolicyRuleSecureTagsExample [Error message] [Debug log]
TestAccComputeFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_update [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Correct the upper limit of priority value in RouterRoutePolicy.yaml.
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 22, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1418
Passed tests: 1327
Skipped tests: 91
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@zli82016 zli82016 added this pull request to the merge queue Apr 22, 2026
Merged via the queue into GoogleCloudPlatform:main with commit c6e423b Apr 22, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants