Skip to content

Reusable rules#17232

Merged
roaks3 merged 8 commits into
GoogleCloudPlatform:mainfrom
XianJiChen:reusable-rules
Apr 28, 2026
Merged

Reusable rules#17232
roaks3 merged 8 commits into
GoogleCloudPlatform:mainfrom
XianJiChen:reusable-rules

Conversation

@XianJiChen
Copy link
Copy Markdown
Contributor

@XianJiChen XianJiChen commented Apr 22, 2026

dataplex: added `attributes`, `template_reference`, `enable_catalog_basedRules`, and `filter` fields to `google_dataplex_datascan` resource

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1810 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 5 files changed, 1810 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 86
Passed tests: 81
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • dataplex

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascanDataplexDatascanFullQuality_update
  • TestAccDataplexDatascan_dataplexDatascanDataQualityTemplateReferenceExample
  • TestAccDataplexDatascan_dataplexDatascanFullQualityTestExample
  • TestAccDataplexDatascan_dataplexDatascanQualityReusableRulesCatalogBasedExample
  • TestAccDataplexDatascan_dataplexDatascanQualityReusableRulesCatalogBased_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataplexDatascan_dataplexDatascanDataQualityTemplateReferenceExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullQualityTestExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanQualityReusableRulesCatalogBasedExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanQualityReusableRulesCatalogBased_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@XianJiChen XianJiChen marked this pull request as ready for review April 22, 2026 02:13
@github-actions github-actions Bot requested a review from roaks3 April 22, 2026 02:14
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@XianJiChen XianJiChen marked this pull request as draft April 22, 2026 02:14
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1811 insertions(+), 31 deletions(-))
google-beta provider: Diff ( 5 files changed, 1811 insertions(+), 31 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 86
Passed tests: 85
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascanDataplexDatascanFullQuality_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@XianJiChen XianJiChen closed this Apr 22, 2026
@XianJiChen XianJiChen reopened this Apr 22, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1811 insertions(+), 31 deletions(-))
google-beta provider: Diff ( 5 files changed, 1811 insertions(+), 31 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 86
Passed tests: 85
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascanDataplexDatascanFullQuality_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1810 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 5 files changed, 1810 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 86
Passed tests: 85
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascanDataplexDatascanFullQuality_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1810 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 5 files changed, 1810 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 86
Passed tests: 85
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascanDataplexDatascanFullQuality_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2173 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 5 files changed, 2173 insertions(+), 26 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 87
Passed tests: 85
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascanDataplexDatascanFullQuality_update
  • TestAccDataplexDatascan_dataplexDatascanDataQualityTemplateReference_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Debug log]
TestAccDataplexDatascan_dataplexDatascanDataQualityTemplateReference_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@XianJiChen XianJiChen marked this pull request as ready for review April 22, 2026 11:56
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2176 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 5 files changed, 2176 insertions(+), 29 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2176 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 5 files changed, 2176 insertions(+), 29 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2173 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 5 files changed, 2173 insertions(+), 26 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2173 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 5 files changed, 2173 insertions(+), 26 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 87
Passed tests: 87
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataplex

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 87
Passed tests: 87
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataplex

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 87
Passed tests: 87
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataplex

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 87
Passed tests: 87
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataplex

🟢 All tests passed!

View the build log

@github-actions
Copy link
Copy Markdown

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@XianJiChen
Copy link
Copy Markdown
Contributor Author

@roaks3 gentle bump

@roaks3 roaks3 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into GoogleCloudPlatform:main with commit d9e3c72 Apr 28, 2026
24 checks passed
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants