Skip to content

feat: expose configId output field in google_discovery_engine_widget_config#17235

Merged
trodge merged 1 commit into
GoogleCloudPlatform:mainfrom
gwendal-lecren:feat/add_config_id
May 7, 2026
Merged

feat: expose configId output field in google_discovery_engine_widget_config#17235
trodge merged 1 commit into
GoogleCloudPlatform:mainfrom
gwendal-lecren:feat/add_config_id

Conversation

@gwendal-lecren
Copy link
Copy Markdown
Contributor

@gwendal-lecren gwendal-lecren commented Apr 22, 2026

This exposes the config_id of the widget config as output only.

Fixes hashicorp/terraform-provider-google#27047

discoveryengine: added `config_id` attribute to `google_discovery_engine_widget_config`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 22, 2026
@github-actions github-actions Bot requested a review from trodge April 22, 2026 10:06
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link
Copy Markdown

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/discoveryengine and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 30, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 24 insertions(+))
google-beta provider: Diff ( 4 files changed, 24 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 40
Passed tests: 35
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_discovery_engine_widget_config: expose the configId

3 participants