Skip to content

[NetworkManagement] Add gke_pod and network_type to google_network_management_connectivity_test#17255

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
modular-apprentice:auto-pr-1776928067886240343
May 28, 2026
Merged

[NetworkManagement] Add gke_pod and network_type to google_network_management_connectivity_test#17255
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
modular-apprentice:auto-pr-1776928067886240343

Conversation

@modular-apprentice
Copy link
Copy Markdown
Contributor

Adds the gke_pod and network_type fields to the destination block of the google_network_management_connectivity_test resource to support GKE Pod and network type specification for destination endpoints. Also includes the corresponding acceptance tests.

networkmanagement: added `gke_pod` and `network_type` fields to `google_network_management_connectivity_test` resource

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 139 insertions(+))
google-beta provider: Diff ( 4 files changed, 139 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • networkmanagement

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestGkePodExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestGkePodExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions
Copy link
Copy Markdown

@ScottSuarez @slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

@GoogleCloudPlatform/terraform-team @ScottSuarez @slevenick This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @ScottSuarez @slevenick This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @ScottSuarez @slevenick This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @ScottSuarez @slevenick This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants