Moved some clients from config.go to individual service packages

[melinath]

This moves a few clients from config.go to their individual service packages, reducing the amount of global code & simplifying a future move to using service packages as the location for BaseUrl computation (instead of global computation in config.go)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 167 insertions(+), 75 deletions(-))
google-beta provider: Diff ( 21 files changed, 240 insertions(+), 129 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 63 deletions(-))

[modular-magician]

Tests analytics

Total tests: 6344
Passed tests: 5668
Skipped tests: 652
Affected tests: 24

Click here to see the affected service packages

All service packages are affected

Action taken

Found 24 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
• TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
• TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
• TestAccCloudRunService_cloudRunServiceGpuExample
• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccContainerCluster_updateVersion
• TestAccContainerCluster_withAutopilotResourceManagerTags
• TestAccContainerCluster_withNodeConfigLinuxNodeConfig
• TestAccContainerNodePool_withHostMaintenancePolicy
• TestAccDataformConfig_update
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
• TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
• TestAccMemorystoreInstance_automatedBackupConfig
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updateEngineVersion
• TestAccMemorystoreInstance_updateInstanceEndpoints
• TestAccMemorystoreInstance_updateNodeType
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount
• TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccContainerCluster_withNodeConfigLinuxNodeConfig [Debug log]
TestAccDataformConfig_update [Debug log]
TestAccMemorystoreInstance_automatedBackupConfig [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Debug log]
TestAccMemorystoreInstance_updateNodeType [Debug log]
TestAccMemorystoreInstance_updatePersistence [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Debug log]
TestAccMemorystoreInstance_updateShardCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_updateVersion [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccContainerNodePool_withHostMaintenancePolicy [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

VCR failures look unrelated.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 167 insertions(+), 75 deletions(-))
google-beta provider: Diff ( 21 files changed, 240 insertions(+), 129 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 26 insertions(+), 63 deletions(-))

[melinath]

TGC failures are unrelated; moving forward with merge since that's all that changed in the last commit.

[modular-magician]

Tests analytics

Total tests: 6344
Passed tests: 5680
Skipped tests: 652
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
• TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
• TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
• TestAccCloudRunService_cloudRunServiceGpuExample
• TestAccContainerCluster_updateVersion
• TestAccContainerCluster_withAutopilotResourceManagerTags
• TestAccContainerNodePool_withHostMaintenancePolicy
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
• TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
• TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_updateVersion [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccContainerNodePool_withHostMaintenancePolicy [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test