Skip to content

Onetime scan fix#17282

Merged
roaks3 merged 2 commits intoGoogleCloudPlatform:mainfrom
XianJiChen:onetime-scan-fix
Apr 24, 2026
Merged

Onetime scan fix#17282
roaks3 merged 2 commits intoGoogleCloudPlatform:mainfrom
XianJiChen:onetime-scan-fix

Conversation

@XianJiChen
Copy link
Copy Markdown
Contributor

@XianJiChen XianJiChen commented Apr 24, 2026

dataplex: fixed acceptance test failure for one time scans

this pr is to fix hashicorp/terraform-provider-google#26716
The tests were failing/flaky because one time datascan triggers a datascan job run right after creation, and since examples scans have trivial setup so the job run could be quick, and therefore, when the pipeline performs import test, it will see the execution_status.0.latest_job_end_time being populated which leads to mismatch.
In this pr we also removed the used of redundant ignore_read_extra for dataplex_datascan_execution_identity_service_account as it uses an on_demand trigger which won't trigger a new scan job.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 83
Passed tests: 83
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataplex

🟢 All tests passed!

View the build log

@XianJiChen XianJiChen marked this pull request as ready for review April 24, 2026 16:53
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from roaks3 April 24, 2026 16:54
@roaks3 roaks3 added this pull request to the merge queue Apr 24, 2026
Merged via the queue into GoogleCloudPlatform:main with commit c956bb4 Apr 24, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDataplexDatascan_dataplexDatascanOnetimeProfileExample

3 participants