Refactor TestAccAccessApprovalSettings loop to use a slice.#17287
Conversation
The test cases are now defined as a slice of structs containing the name and the test function, instead of a map. This removes the need for shadowing the loop variable. also added in more sleep time.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
I did everything in go/terraform-auto-test-runs on april 21, but I still can't access https://github.com/orgs/GoogleCloudPlatform/teams/terraform-autotest-contributors, so I don't think its working yet (though it says it should work after 24 hours.) |
I can manually approve the build, don't worry about it. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
looks like the tests I was trying to fix are now passing on this PR: http://shortn/_jUwjx2atOP |
745aa1b
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.