Skip to content

Refactor TestAccAccessApprovalSettings loop to use a slice.#17287

Merged
hao-nan-li merged 1 commit intoGoogleCloudPlatform:mainfrom
sampcr-google:fix-TestAccAccessApprovalSettings
Apr 24, 2026
Merged

Refactor TestAccAccessApprovalSettings loop to use a slice.#17287
hao-nan-li merged 1 commit intoGoogleCloudPlatform:mainfrom
sampcr-google:fix-TestAccAccessApprovalSettings

Conversation

@sampcr-google
Copy link
Copy Markdown
Contributor

@sampcr-google sampcr-google commented Apr 24, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


The test cases are now defined as a slice of structs containing the name and the test function, instead of a map. This removes the need for shadowing the loop variable.

also added in more sleep time.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 24, 2026
@github-actions github-actions Bot requested a review from hao-nan-li April 24, 2026 16:47
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@sampcr-google
Copy link
Copy Markdown
Contributor Author

I did everything in go/terraform-auto-test-runs on april 21, but I still can't access https://github.com/orgs/GoogleCloudPlatform/teams/terraform-autotest-contributors, so I don't think its working yet (though it says it should work after 24 hours.)

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 24, 2026
@hao-nan-li
Copy link
Copy Markdown
Contributor

I did everything in go/terraform-auto-test-runs on april 21, but I still can't access https://github.com/orgs/GoogleCloudPlatform/teams/terraform-autotest-contributors, so I don't think its working yet (though it says it should work after 24 hours.)

I can manually approve the build, don't worry about it.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 22 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 1 file changed, 22 insertions(+), 13 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • accessapproval

🟢 All tests passed!

View the build log

@sampcr-google
Copy link
Copy Markdown
Contributor Author

looks like the tests I was trying to fix are now passing on this PR: http://shortn/_jUwjx2atOP

@hao-nan-li hao-nan-li added this pull request to the merge queue Apr 24, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 745aa1b Apr 24, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants