Moved clients for sql, backupdr, dataflow, resourcemanager, and resourcemanagerv3#17355
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
TGC integration failures look unrelated - cancelled build to resolve merge conflict |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I had to resolve some merge conflicts, so I also reverted the one change from resourcemanager to resourcemanagerv3 and deleted all recorded cassettes for this PR, so that (hopefully) more tests will be able to pass in replaying mode. If we want to change what client is used for that one request it can happen separately. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b73d8c0: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @melinath, @SirGitsalot VCR tests complete for b73d8c0! |
|
VCR test failures look unrelated. TGC integration failures look unrelated. @SirGitsalot this is ready for review. |
SirGitsalot
left a comment
There was a problem hiding this comment.
I was wondering if there was a circular dependency in there. The resources I had scanned through close-but-not-quite circular ("bar_test" imports "foo", "foo_test" imports "bar").
d869110
Notable things:
https://github.com/GoogleCloudPlatform/magic-modules/pull/17355/changes#diff-ca66a7155e8981fb2be0fad8e381b8fc0de67bf274bf06c13826cdcd84d42ffaL141 changes a call from resourcemanager client to a resourcemanagerv3 client. This seems like an oversight in the previous code, but if it ends up causing problems I'll have to switch it back.After this batch, there are 8 clients remaining in config.go.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.