Skip to content

Moved clients for sql, backupdr, dataflow, resourcemanager, and resourcemanagerv3#17355

Merged
melinath merged 8 commits intoGoogleCloudPlatform:mainfrom
melinath:move-clients-4
May 1, 2026
Merged

Moved clients for sql, backupdr, dataflow, resourcemanager, and resourcemanagerv3#17355
melinath merged 8 commits intoGoogleCloudPlatform:mainfrom
melinath:move-clients-4

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented Apr 30, 2026

Notable things:

After this batch, there are 8 clients remaining in config.go.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@melinath
Copy link
Copy Markdown
Member Author

TGC integration failures look unrelated - cancelled build to resolve merge conflict

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 1, 2026

I had to resolve some merge conflicts, so I also reverted the one change from resourcemanager to resourcemanagerv3 and deleted all recorded cassettes for this PR, so that (hopefully) more tests will be able to pass in replaying mode. If we want to change what client is used for that one request it can happen separately.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 1, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b73d8c0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 68 files changed, 483 insertions(+), 284 deletions(-)
google-beta provider View Diff 70 files changed, 490 insertions(+), 290 deletions(-)
terraform-google-conversion View Diff 13 files changed, 109 insertions(+), 95 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6385 5716 655 14
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_updateVersion
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFirebaseAILogicConfig_firebaseailogicConfigUpdate
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log


Step 2: Recording Mode

Test Name Recording Mode Replaying Rerun
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample 🔴 Failed [Error message] [Debug log] -
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample 🔴 Failed [Error message] [Debug log] -
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample 🔴 Failed [Error message] [Debug log] -
TestAccCloudRunService_cloudRunServiceGpuExample 🔴 Failed [Error message] [Debug log] -
TestAccContainerCluster_updateVersion 🔴 Failed [Error message] [Debug log] -
TestAccContainerCluster_withAutopilotResourceManagerTags 🔴 Failed [Error message] [Debug log] -
TestAccContainerNodePool_withHostMaintenancePolicy 🔴 Failed [Error message] [Debug log] -
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample 🔴 Failed [Error message] [Debug log] -
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample 🔴 Failed [Error message] [Debug log] -
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample 🔴 Failed [Error message] [Debug log] -
TestAccFirebaseAILogicConfig_firebaseailogicConfigUpdate 🟢 Passed [Debug log] 🟢 Passed
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample 🔴 Failed [Error message] [Debug log] -
TestAccProjectIamMemberRemove_memberInMultipleBindings 🟢 Passed [Debug log] 🔴 Failed [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample 🔴 Failed [Error message] [Debug log] -

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@melinath, @SirGitsalot VCR tests complete for b73d8c0!

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 1, 2026

VCR test failures look unrelated. TGC integration failures look unrelated.

@SirGitsalot this is ready for review.

Copy link
Copy Markdown
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if there was a circular dependency in there. The resources I had scanned through close-but-not-quite circular ("bar_test" imports "foo", "foo_test" imports "bar").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants