Handle *BasePath replacement with BaseUrl func#17385
Handle *BasePath replacement with BaseUrl func#17385melinath wants to merge 6 commits intoGoogleCloudPlatform:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
1770466 to
95cffb6
Compare
95cffb6 to
c21959b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
We need this as a compatibility shim for now, while there are still direct references to BasePath
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cadd6fe: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. |
This is essentially a compatibility shim to allow pulling base paths from the product registry + config so that we can safely remove BasePath fields from the config object while (most likely) working on a more thorough migration.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.