Skip to content

Fixed cloud run v1 tests#17465

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:fix-cloudrun-tests
May 7, 2026
Merged

Fixed cloud run v1 tests#17465
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:fix-cloudrun-tests

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented May 7, 2026

#17321 "broke" these tests by fixing URL building for the check_destroy step. The delete is apparently asynchronous, so I've added a short sleep via custom test_check_destroy logic.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@melinath

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from BBBmau May 7, 2026 21:28
@melinath melinath changed the title Added short sleep before checking for cloud run service destruction Fixed cloud run v1 tests May 7, 2026
@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 7, 2026

@modular-magician reassign-reviewer

@github-actions github-actions Bot requested review from zli82016 and removed request for BBBmau May 7, 2026 21:30
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 7, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8d50c3b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 7 insertions(+), 1 deletion(-)
google-beta provider View Diff 2 files changed, 7 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
38 27 8 3
Affected Service Packages
  • cloudrun

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccDataSourceGoogleCloudRunService_basic
  • TestAccDataSourceGoogleCloudRunService_optionalProject

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataSourceGoogleCloudRunService_basic
✅ Log TestAccDataSourceGoogleCloudRunService_optionalProject
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@melinath, @zli82016 VCR tests complete for 8d50c3b!

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 7, 2026

The remaining failure is unrelated - a quota issue.

@melinath melinath added this pull request to the merge queue May 7, 2026
Merged via the queue into GoogleCloudPlatform:main with commit e2f9679 May 7, 2026
23 of 24 checks passed
@melinath melinath deleted the fix-cloudrun-tests branch May 7, 2026 22:14
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants