Skip to content

Moved kms bootstrapping funcs into service package#17521

Merged
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
melinath:split-bootstrap-4
May 12, 2026
Merged

Moved kms bootstrapping funcs into service package#17521
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
melinath:split-bootstrap-4

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented May 12, 2026

This required adding a bunch more test_constants file references. Possibly we could automatically determine the list of services required based on examples, but I want to handle thinking about that separately.

Some of the KMS bootstrapping was actually only used by KMS tests, so I put that in the kms test package to simplify dependencies.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


This required adding a bunch more test_constants file references. Possibly we could automatically determine the list of services required based on examples, but I want to handle thinking about that separately.
@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6530aa8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 124 files changed, 1014 insertions(+), 605 deletions(-)
google-beta provider View Diff 134 files changed, 1075 insertions(+), 631 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6421 5750 657 14
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccEphemeralServiceAccountKey_create
  • TestAccEphemeralServiceAccountKey_upload
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccDataformConfig_update
✅ Log ❌ Error · Log TestAccEphemeralServiceAccountKey_create
✅ Log ❌ Error · Log TestAccEphemeralServiceAccountKey_upload
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@melinath VCR tests complete for 6530aa8!

Copy link
Copy Markdown
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yowza that's a lot of bootstrapped keys

@melinath
Copy link
Copy Markdown
Member Author

yeah!

@melinath
Copy link
Copy Markdown
Member Author

VCR failures look unrelated.

@melinath melinath added this pull request to the merge queue May 12, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 239e5f4 May 12, 2026
22 of 23 checks passed
@melinath melinath deleted the split-bootstrap-4 branch May 12, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants