Moved kms bootstrapping funcs into service package#17521
Conversation
This required adding a bunch more test_constants file references. Possibly we could automatically determine the list of services required based on examples, but I want to handle thinking about that separately.
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6530aa8: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. |
SirGitsalot
left a comment
There was a problem hiding this comment.
Yowza that's a lot of bootstrapped keys
|
yeah! |
|
VCR failures look unrelated. |
239e5f4
This required adding a bunch more test_constants file references. Possibly we could automatically determine the list of services required based on examples, but I want to handle thinking about that separately.
Some of the KMS bootstrapping was actually only used by KMS tests, so I put that in the kms test package to simplify dependencies.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.