Skip to content

feat: google ces deployment Add missing securitySettings fields to we…#17566

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
sirohia:feat-ces-web-widget
May 14, 2026
Merged

feat: google ces deployment Add missing securitySettings fields to we…#17566
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
sirohia:feat-ces-web-widget

Conversation

@sirohia
Copy link
Copy Markdown
Contributor

@sirohia sirohia commented May 14, 2026

Add missing securitySettings fields to webWidgetConfig in ces_deployment

This PR adds missing fields to web_widget_config in the google_ces_deployment resource to match the REST API, and fixes some discrepancies in existing fields.

Documentation

https://docs.cloud.google.com/customer-engagement-ai/conversational-agents/ps/reference/rest/v1/ChannelProfile#ChannelProfile.WebWidgetConfig

Rationale

The web_widget_config in google_ces_deployment had limited support compared to the REST API. Specifically, securitySettings and its sub-fields were missing, which are needed for configuring allowed origins and reCAPTCHA.

Technical Details

  • Added Fields: Added securitySettings with enablePublicAccess, enableOriginCheck, allowedOrigins, and enableRecaptcha to Deployment.yaml.
  • Fixed Discrepancies:
    • Updated channelType to include missing values: FIVE9 and CONTACT_CENTER_INTEGRATION.
    • Updated modality to use MODALITY_UNSPECIFIED and add CHAT_VOICE_AND_VIDEO.
    • Updated theme to use THEME_UNSPECIFIED.
  • Boolean Handling: Used send_empty_value: true for boolean fields to ensure false values are propagated to the API.
  • Testing:
    • Created a new example file ces_deployment_full.tf.tmpl to showcase the new fields.
    • Updated ces_deployment_test.go to include update tests for the new fields, specifically testing toggling from true to false.

Verification Results

  • Code generation successful for both GA and Beta.
  • Acceptance tests passed successfully in both GA and Beta providers.
  • Manual verification in a test project confirmed that the fields are correctly stored in the backend.
ces: added `security_settings` field to `google_ces_deployment` resource
ces: updated supported values for `channel_type`, `modality`, and `theme` in `google_ces_deployment`

@github-actions github-actions Bot requested a review from slevenick May 14, 2026 20:08
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 14, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a3dd3d1:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 307 insertions(+), 6 deletions(-)
google-beta provider View Diff 5 files changed, 307 insertions(+), 6 deletions(-)
terraform-google-conversion View Diff 1 file changed, 66 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 135 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
64 61 0 3
Affected Service Packages
  • ces

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCESApp_update
  • TestAccCESDeployment_cesDeploymentFullExample
  • TestAccCESDeployment_update

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCESApp_update
✅ Log TestAccCESDeployment_cesDeploymentFullExample
✅ Log TestAccCESDeployment_update

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@sirohia, @slevenick VCR tests complete for a3dd3d1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants