feat: google ces deployment Add missing securitySettings fields to we…#17566
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a3dd3d1: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
🟢 All tests passed! View the build log or the debug logs folder for detailed results. @sirohia, @slevenick VCR tests complete for a3dd3d1! |
0eb17e0
Add missing securitySettings fields to webWidgetConfig in ces_deployment
This PR adds missing fields to
web_widget_configin thegoogle_ces_deploymentresource to match the REST API, and fixes some discrepancies in existing fields.Documentation
https://docs.cloud.google.com/customer-engagement-ai/conversational-agents/ps/reference/rest/v1/ChannelProfile#ChannelProfile.WebWidgetConfig
Rationale
The
web_widget_configingoogle_ces_deploymenthad limited support compared to the REST API. Specifically,securitySettingsand its sub-fields were missing, which are needed for configuring allowed origins and reCAPTCHA.Technical Details
securitySettingswithenablePublicAccess,enableOriginCheck,allowedOrigins, andenableRecaptchatoDeployment.yaml.channelTypeto include missing values:FIVE9andCONTACT_CENTER_INTEGRATION.modalityto useMODALITY_UNSPECIFIEDand addCHAT_VOICE_AND_VIDEO.themeto useTHEME_UNSPECIFIED.send_empty_value: truefor boolean fields to ensurefalsevalues are propagated to the API.ces_deployment_full.tf.tmplto showcase the new fields.ces_deployment_test.goto include update tests for the new fields, specifically testing toggling from true to false.Verification Results