Skip to content

Add migration center report resource and tests#17574

Merged
slevenick merged 2 commits into
GoogleCloudPlatform:mainfrom
slevenick:migration-center-report
May 26, 2026
Merged

Add migration center report resource and tests#17574
slevenick merged 2 commits into
GoogleCloudPlatform:mainfrom
slevenick:migration-center-report

Conversation

@slevenick
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_migration_center_report`

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 15, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2d83272:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 4493 insertions(+)
google-beta provider View Diff 4 files changed, 4493 insertions(+)
terraform-google-conversion View Diff 1 file changed, 145 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 128 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_migration_center_report (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_migration_center_report" "primary" {
  summary {
    all_assets_stats {
      core_count_histogram {
        buckets {
          count       = # value needed
          lower_bound = # value needed
          upper_bound = # value needed
        }
      }
      memory_bytes_histogram {
        buckets {
          count       = # value needed
          lower_bound = # value needed
          upper_bound = # value needed
        }
      }
      memory_utilization_chart {
        free = # value needed
        used = # value needed
      }
      operating_system {
        data_points {
          label = # value needed
          value = # value needed
        }
      }
      software_instances {
        data_points {
          label = # value needed
          value = # value needed
        }
      }
      storage_bytes_histogram {
        buckets {
          count       = # value needed
          lower_bound = # value needed
          upper_bound = # value needed
        }
      }
      storage_utilization_chart {
        free = # value needed
        used = # value needed
      }
      total_assets        = # value needed
      total_cores         = # value needed
      total_memory_bytes  = # value needed
      total_storage_bytes = # value needed
    }
    group_findings {
      asset_aggregate_stats {
        core_count_histogram {
          buckets {
            count       = # value needed
            lower_bound = # value needed
            upper_bound = # value needed
          }
        }
        memory_bytes_histogram {
          buckets {
            count       = # value needed
            lower_bound = # value needed
            upper_bound = # value needed
          }
        }
        memory_utilization_chart {
          free = # value needed
          used = # value needed
        }
        operating_system {
          data_points {
            label = # value needed
            value = # value needed
          }
        }
        software_instances {
          data_points {
            label = # value needed
            value = # value needed
          }
        }
        storage_bytes_histogram {
          buckets {
            count       = # value needed
            lower_bound = # value needed
            upper_bound = # value needed
          }
        }
        storage_utilization_chart {
          free = # value needed
          used = # value needed
        }
        total_assets        = # value needed
        total_cores         = # value needed
        total_memory_bytes  = # value needed
        total_storage_bytes = # value needed
      }
      description             = # value needed
      display_name            = # value needed
      overlapping_asset_count = # value needed
      preference_set_findings {
        compute_engine_finding {
          allocated_asset_count = # value needed
          allocated_disk_types  = # value needed
          allocated_regions     = # value needed
          machine_series_allocations {
            allocated_asset_count = # value needed
            machine_series {
              code = # value needed
            }
          }
        }
        description  = # value needed
        display_name = # value needed
        machine_preferences {
          commitment_plan = # value needed
          compute_engine_preferences {
            license_type = # value needed
            machine_preferences {
              allowed_machine_series {
                code = # value needed
              }
            }
            persistent_disk_type = # value needed
          }
          region_preferences {
            preferred_regions = # value needed
          }
          sizing_optimization_strategy = # value needed
          sole_tenancy_preferences {
            commitment_plan         = # value needed
            cpu_overcommit_ratio    = # value needed
            host_maintenance_policy = # value needed
            node_types {
              node_name = # value needed
            }
          }
          target_product = # value needed
          vmware_engine_preferences {
            commitment_plan                         = # value needed
            cpu_overcommit_ratio                    = # value needed
            memory_overcommit_ratio                 = # value needed
            storage_deduplication_compression_ratio = # value needed
          }
        }
        monthly_cost_compute {
          currency_code = # value needed
          nanos         = # value needed
          units         = # value needed
        }
        monthly_cost_network_egress {
          currency_code = # value needed
          nanos         = # value needed
          units         = # value needed
        }
        monthly_cost_os_license {
          currency_code = # value needed
          nanos         = # value needed
          units         = # value needed
        }
        monthly_cost_other {
          currency_code = # value needed
          nanos         = # value needed
          units         = # value needed
        }
        monthly_cost_storage {
          currency_code = # value needed
          nanos         = # value needed
          units         = # value needed
        }
        monthly_cost_total {
          currency_code = # value needed
          nanos         = # value needed
          units         = # value needed
        }
        sole_tenant_finding {
          allocated_asset_count = # value needed
          allocated_regions     = # value needed
          node_allocations {
            allocated_asset_count = # value needed
            node {
              node_name = # value needed
            }
            node_count = # value needed
          }
        }
        vmware_engine_finding {
          allocated_asset_count = # value needed
          allocated_regions     = # value needed
          node_allocations {
            allocated_asset_count = # value needed
            node_count            = # value needed
            vmware_node {
              code = # value needed
            }
          }
        }
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
7 6 0 1
Affected Service Packages
  • migrationcenter

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccMigrationCenterReport_migrationCenterReportBasicExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccMigrationCenterReport_migrationCenterReportBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 2d83272!

@slevenick
Copy link
Copy Markdown
Contributor Author

slevenick commented May 15, 2026

Depends on ReportConfig resource introduced in #17580

@slevenick slevenick force-pushed the migration-center-report branch from 2d83272 to c9c9989 Compare May 26, 2026 19:49
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 26, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c9c9989:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 4458 insertions(+)
google-beta provider View Diff 4 files changed, 4458 insertions(+)
terraform-google-conversion View Diff 1 file changed, 145 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 128 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
12 11 0 1
Affected Service Packages
  • migrationcenter

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccMigrationCenterReport_migrationCenterReportBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccMigrationCenterReport_migrationCenterReportBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for c9c9989!

@slevenick slevenick requested review from a team and trodge and removed request for a team May 26, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants