Add migration center assets export job resource and tests#17575
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4253722: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_migration_center_assets_export_job" "primary" {
condition {
filter = # value needed
}
recent_executions {
result {
error {
code = # value needed
message = # value needed
}
}
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
🟢 All tests passed! View the build log or the debug logs folder for detailed results. @slevenick VCR tests complete for 4253722! |
roaks3
left a comment
There was a problem hiding this comment.
I had a non-blocking nit, but my understanding on the inheritance could be wrong or outdated. Otherwise LGTM.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2ee4438: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_migration_center_assets_export_job" "primary" {
condition {
filter = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @slevenick VCR tests complete for 2ee4438! |
f8dabe7
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.