Skip to content

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"#18084

Merged
SirGitsalot merged 2 commits into
GoogleCloudPlatform:mainfrom
guvenenb:revert-17944-online_evals
Jun 29, 2026
Merged

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"#18084
SirGitsalot merged 2 commits into
GoogleCloudPlatform:mainfrom
guvenenb:revert-17944-online_evals

Conversation

@guvenenb

@guvenenb guvenenb commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Release Note

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"

This reverts the changes introduced in #17944.

Supersedes #18038

The `google_vertex_ai_online_evaluator` resource has been reverted.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 25, 2026
@github-actions github-actions Bot requested a review from rileykarson June 25, 2026 10:42
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

if [ "${{ github.event_name }}" == "pull_request" ]; then
# For PRs, get only changed files
yamlfiles=$(git diff --name-only origin/${GITHUB_BASE_REF} -- mmv1/products)
yamlfiles=$(git diff --name-only --diff-filter=d origin/${GITHUB_BASE_REF} -- mmv1/products)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this change to pass the CI. Otherwise it is giving some error b because the YAML linter tries to lint the deleted file and fails

@rileykarson

Copy link
Copy Markdown
Member

@modular-magician reassign-reviewer SirGitsALot

@github-actions github-actions Bot requested review from SirGitsalot and removed request for rileykarson June 28, 2026 23:53
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 29, 2026
@modular-magician

modular-magician commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 477fcd1:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 358 deletions(-)
google-beta provider View Diff 6 files changed, 2400 deletions(-)
terraform-google-conversion View Diff 1 file changed, 465 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_vertex_ai_online_evaluator was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

  • Error reading file website/docs/r/vertex_ai_online_evaluator.html.markdown

Test report

Analytics

Total Tests Passed Skipped Affected
100 96 4 0
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@guvenenb, @SirGitsalot VCR tests complete for 477fcd1!

@SirGitsalot SirGitsalot added the override-breaking-change Allows a potential breaking change to be merged label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override-breaking-change Allows a potential breaking change to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants