Support policy version 3 in google_spanner_database_iam_member and google_spanner_instance_iam_member by rahul2393 · Pull Request #6915 · GoogleCloudPlatform/magic-modules

rahul2393 · 2022-12-06T15:46:16Z

Fixes hashicorp/terraform-provider-google#13060

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

spanner: added support for IAM conditions with `google_spanner_database_iam_member` and `google_spanner_instance_iam_member`

modular-magician · 2022-12-06T15:46:31Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-12-06T15:47:14Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

rahul2393 · 2022-12-06T15:53:53Z

/gcbrun

modular-magician · 2022-12-06T16:04:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+))
TF Validator: Diff ( 4 files changed, 11 insertions(+), 3 deletions(-))

modular-magician · 2022-12-06T16:34:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+))
TF Validator: Diff ( 4 files changed, 11 insertions(+), 3 deletions(-))

modular-magician · 2022-12-06T17:19:32Z

Tests analytics

Total tests: 2325
Passed tests 2075
Skipped tests: 244
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerNodePool_withUpgradeSettings|TestAccLoggingBucketConfigProject_cmekSettings|TestAccSpannerDatabaseIamMember|TestAccSpannerDatabaseIamBinding|TestAccSpannerInstanceIamMember|TestAccSpannerInstanceIamBinding

modular-magician · 2022-12-06T17:35:31Z

Tests passed during RECORDING mode:
TestAccContainerNodePool_withUpgradeSettings[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccSpannerDatabaseIamMember[Debug log]
TestAccSpannerDatabaseIamBinding[Debug log]
TestAccSpannerInstanceIamMember[Debug log]
TestAccSpannerInstanceIamBinding[Debug log]

All tests passed
View the build log or the debug log for each test

slevenick

Can you add a test that uses IAM conditions for spanner_instance & spanner_database tests?

…_iam resources

modular-magician · 2023-01-17T14:09:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+))
TF Validator: Diff ( 4 files changed, 11 insertions(+), 3 deletions(-))

rahul2393 · 2023-01-17T14:59:39Z

/gcbrun

modular-magician · 2023-01-17T15:01:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 16 insertions(+))
Terraform Beta: Diff ( 4 files changed, 16 insertions(+))
TF Validator: Diff ( 4 files changed, 11 insertions(+), 3 deletions(-))

modular-magician · 2023-01-17T15:42:47Z

Tests analytics

Total tests: 2419
Passed tests 2164
Skipped tests: 252
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccSpannerInstanceIamMember|TestAccSpannerDatabaseIamMember

modular-magician · 2023-01-17T15:44:02Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

Tests failed during RECORDING mode:
TestAccSpannerInstanceIamMember[Error message] [Debug log]
TestAccSpannerDatabaseIamMember[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-17T17:35:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 22 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 22 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 17 insertions(+), 5 deletions(-))

rahul2393 · 2023-01-17T17:41:03Z

/gcbrun

modular-magician · 2023-01-17T18:19:24Z

Tests analytics

Total tests: 2419
Passed tests 2159
Skipped tests: 252
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccSpannerInstanceIamPolicy|TestAccSpannerInstanceIamMember|TestAccSpannerInstanceIamBinding|TestAccSpannerDatabaseIamPolicy|TestAccSpannerDatabaseIamMember|TestAccSpannerDatabaseIamBinding|TestAccRegionInstanceGroupManager_stateful

modular-magician · 2023-01-17T18:23:10Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]
TestAccSpannerInstanceIamBinding[Debug log]
TestAccSpannerDatabaseIamPolicy[Debug log]
TestAccSpannerDatabaseIamBinding[Debug log]

Tests failed during RECORDING mode:
TestAccSpannerInstanceIamMember[Error message] [Debug log]
TestAccSpannerDatabaseIamMember[Error message] [Debug log]
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

slevenick · 2023-01-17T18:57:34Z

Looks like the tests are failing due to these changes. Are you able to run them locally?

rahul2393 · 2023-01-17T19:00:43Z

I tested on local by building provider and running it, its working fine, but I am not able to figure out why tests are failing

rahul2393 · 2023-01-17T19:01:21Z

@slevenick please help if you are able to figure out issue

slevenick · 2023-01-17T19:18:21Z

=== CONT TestAccSpannerInstanceIamMember
provider_test.go:315: Step 2/2 error running import: exit status 1

    Error: Cannot find binding for "Spanner Instance: project/tf-test-t0goukwv8s" with role "roles/spanner.databaseAdmin", member "serviceAccount:tf-test-5491200468017463976@project.iam.gserviceaccount.com", and condition title ""

--- FAIL: TestAccSpannerInstanceIamMember (29.40s)
FAIL

slevenick · 2023-01-17T19:25:04Z

/gcbrun

modular-magician · 2023-01-17T19:41:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 22 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 22 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 17 insertions(+), 5 deletions(-))

modular-magician · 2023-01-17T20:22:43Z

Tests analytics

Total tests: 2420
Passed tests 2165
Skipped tests: 252
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSpannerInstanceIamMember|TestAccSpannerDatabaseIamMember|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2023-01-17T20:23:34Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccSpannerInstanceIamMember[Error message] [Debug log]
TestAccSpannerDatabaseIamMember[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rahul2393 · 2023-01-18T15:52:05Z

/gcbrun

modular-magician · 2023-01-18T15:54:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 28 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 28 insertions(+), 6 deletions(-))
TF Validator: Diff ( 4 files changed, 17 insertions(+), 5 deletions(-))

modular-magician · 2023-01-18T16:34:34Z

Tests analytics

Total tests: 2423
Passed tests 2164
Skipped tests: 252
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_UpdateComposerV2WithTriggerer|TestAccComposerEnvironment_ComposerV2|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccSpannerDatabaseIamMember|TestAccSpannerInstanceIamMember

modular-magician · 2023-01-18T17:49:36Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComposerEnvironment_ComposerV2[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccSpannerDatabaseIamMember[Debug log]
TestAccSpannerInstanceIamMember[Debug log]

Tests failed during RECORDING mode:
TestAccComposerEnvironment_UpdateComposerV2[Error message] [Debug log]
TestAccComposerEnvironment_UpdateComposerV2WithTriggerer[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rahul2393 · 2023-01-19T02:38:06Z

/gcbrun

rahul2393 · 2023-01-19T02:39:38Z

@slevenick I have fixed the tests modified in this PR, unrelated tests failed in the last run I suspect they are flacky, can you help re-trigger tests?

rahul2393 · 2023-01-20T06:10:04Z

/gcbrun

melinath · 2023-01-20T16:29:48Z

/gcbrun

modular-magician · 2023-01-20T16:49:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 28 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 28 insertions(+), 6 deletions(-))
TF Validator: Diff ( 4 files changed, 17 insertions(+), 5 deletions(-))

modular-magician · 2023-01-20T17:37:37Z

Tests analytics

Total tests: 2423
Passed tests 2168
Skipped tests: 253
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComposerEnvironment_ComposerV2|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

modular-magician · 2023-01-20T18:27:44Z

Tests passed during RECORDING mode:
TestAccComposerEnvironment_ComposerV2[Debug log]

Tests failed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

slevenick

Thanks! Just updated the changelog note to refer to adding conditions which is the actual change a user would see

…ogle_spanner_instance_iam_member (GoogleCloudPlatform#6915) * support policy version 3 in spanner_database_iam and spanner_instance_iam resources * re-trigger checks * update tests to have conditions * fix tests * fix tests

modular-magician requested a review from slevenick December 6, 2022 15:47

slevenick requested changes Dec 6, 2022

View reviewed changes

rahul2393 added 2 commits January 17, 2023 19:22

support policy version 3 in spanner_database_iam and spanner_instance…

eb39cef

…_iam resources

re-trigger checks

921726b

modular-magician requested a review from slevenick January 17, 2023 13:54

update tests to have conditions

a38a865

fix tests

7edb73f

fix tests

1abebcb

slevenick approved these changes Jan 24, 2023

View reviewed changes

slevenick merged commit 5f7d3d9 into GoogleCloudPlatform:main Jan 24, 2023

Conversation

rahul2393 commented Dec 6, 2022 • edited by slevenick Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Dec 6, 2022

Uh oh!

modular-magician commented Dec 6, 2022

Uh oh!

rahul2393 commented Dec 6, 2022

Uh oh!

modular-magician commented Dec 6, 2022

Diff report

Uh oh!

modular-magician commented Dec 6, 2022

Diff report

Uh oh!

modular-magician commented Dec 6, 2022

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 6, 2022

Uh oh!

slevenick left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jan 17, 2023

Diff report

Uh oh!

rahul2393 commented Jan 17, 2023

Uh oh!

modular-magician commented Jan 17, 2023

Diff report

Uh oh!

modular-magician commented Jan 17, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 17, 2023

Uh oh!

modular-magician commented Jan 17, 2023

Diff report

Uh oh!

rahul2393 commented Jan 17, 2023

Uh oh!

modular-magician commented Jan 17, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 17, 2023

Uh oh!

slevenick commented Jan 17, 2023

Uh oh!

rahul2393 commented Jan 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rahul2393 commented Jan 17, 2023

Uh oh!

slevenick commented Jan 17, 2023

Uh oh!

slevenick commented Jan 17, 2023

Uh oh!

modular-magician commented Jan 17, 2023

Diff report

Uh oh!

modular-magician commented Jan 17, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 17, 2023

Uh oh!

rahul2393 commented Jan 18, 2023

Uh oh!

modular-magician commented Jan 18, 2023

Diff report

Uh oh!

modular-magician commented Jan 18, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 18, 2023

rahul2393 commented Dec 6, 2022 •

edited by slevenick

Loading

rahul2393 commented Jan 17, 2023 •

edited

Loading