chore(functions/logging): exclude trace code from sample#2326
Merged
JustinBeckwith merged 7 commits intomainfrom Sep 24, 2021
Merged
chore(functions/logging): exclude trace code from sample#2326JustinBeckwith merged 7 commits intomainfrom
JustinBeckwith merged 7 commits intomainfrom
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
product-auto-label
Bot
added
api: cloudfunctions
google-cla
Bot
added
the
cla: yes
ace-n
changed the title
JustinBeckwith
approved these changes
Sep 1, 2021
grayside
requested changes
Sep 1, 2021
Collaborator
grayside
left a comment
grayside
left a comment
There was a problem hiding this comment.
Trying to hit pause on this set of changes, as it removes information relevant for HTTP functions users to avoid confusing Background Functions users. I'd prefer to find another way.
added 2 commits
September 7, 2021 18:28
Contributor
Author
|
@grayside went with the solution we discussed; PTAL? |
grayside
approved these changes
Sep 24, 2021
noerog
pushed a commit
that referenced
this pull request
Sep 2, 2022
* chore(functions/logging): exclude HTTP-specific trace code from sample * Fix region tag * Apply Adam's suggested fix Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for b/183751712