chore: Update runtime version to 20 for appengine sample#3643
Closed
heypisha wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
Closed
chore: Update runtime version to 20 for appengine sample#3643heypisha wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
heypisha wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
nodejs16 runtime is outdated and throws an error that its support has expired. Updating to the latest, nodejs20, that has support through 2026-04-30.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
Bot
added
samples
iennae
changed the title
1 task
Contributor
|
@pierrettemugisha appreciate you creating this quick fix. I've gone ahead and replaced with a larger update to app engine samples for standard environment with #3657 . As I can branch the repository, tests can run within the PR. I'm going to go ahead and close this PR. |
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
Node.js 10, 12, 14, and 16 have reached end of support on January 30, 2024. Existing applications using these versions will continue to run and receive traffic. This update to samples ensures new deploys will work as expected. ## Description Fixes #3645 Fixes #3642 Replaces #3643 ## Checklist - [X] Please **merge** this PR for me once it is approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs16 runtime is outdated and throws an error that its support has expired. Updating to the latest, nodejs20, that has support through 2026-04-30.
Description
Fixes #3642
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.