Skip to content

chore(gae): Remove older region tag #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hivanalejandro wants to merge 2 commits into from
Closed

chore(gae): Remove older region tag #4032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab17e67
chore(gae): Remove older region tag
hivanalejandro Mar 20, 2025
f13ac73
Merge branch 'main' into hivanalejandro-migrate-region-step4-401218453
iennae Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions appengine/building-an-app/update/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,5 @@
# limitations under the License.

# [START gae_app_yaml]
Copy link
Contributor

@eapl-gemugami eapl-gemugami Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The fixed region tag requires a language suffix for node

See polls.yaml#L25 as an example, and the internal resource naming-a-new-region-tag

  1. Also I'd recommend adding more context, as app is too broad.
    Perhaps gae_update_app_yaml_node

Copy link
Contributor

@eapl-gemugami eapl-gemugami Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You seem to have a conflict with region tag gae_app_yaml. See my review in PR chore(gae): Remove older region tag #4018.

# [START app_yaml]
runtime: nodejs20
# [END app_yaml]
# [END gae_app_yaml]
Loading