feat(storage): migrate requester pays samples and tests#4265
feat(storage): migrate requester pays samples and tests#4265iennae merged 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Google Cloud Storage Node.js samples by introducing a suite of new examples for managing the 'Requester Pays' feature on buckets. It provides developers with clear demonstrations of how to programmatically control who pays for data access, alongside a new utility sample for fetching project service account details. These additions aim to provide more complete coverage of common storage operations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new samples for Google Cloud Storage related to 'Requester Pays' functionality and retrieving service account details. It includes new JavaScript files for enabling, disabling, getting the status of, and downloading files with Requester Pays, as well as a sample for getting the service account. Corresponding system tests have been added. Feedback includes improving error handling in the cleanup script's promise chain and fixing a skipped test in requesterPays.test.js to correctly capture stderr using spawnSync.
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.