Skip to content

refactor(run/image-processing): replace deprecated gm library with sharp#4297

Merged
iennae merged 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:refactor/run-image-processing-gm-to-sharp
Apr 22, 2026
Merged

refactor(run/image-processing): replace deprecated gm library with sharp#4297
iennae merged 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:refactor/run-image-processing-gm-to-sharp

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented Apr 21, 2026

Description

Fixes internal: b/503844690

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal requested review from a team as code owners April 21, 2026 19:29
@angelcaamal angelcaamal added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Apr 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the ImageMagick-based gm library with sharp for image processing and adds a check to prevent recursive execution when events are triggered by the destination bucket. A review comment identifies a potential resource leak because the file cleanup logic is not scoped to cover processing failures, and it points out that fs.unlink is being incorrectly used as a promise-based function instead of fs.promises.unlink.

Comment thread run/image-processing/image.js
@iennae iennae merged commit 6edfeda into GoogleCloudPlatform:main Apr 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants