refactor(run/image-processing): replace deprecated gm library with sharp#4297
Merged
iennae merged 2 commits intoGoogleCloudPlatform:mainfrom Apr 22, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the ImageMagick-based gm library with sharp for image processing and adds a check to prevent recursive execution when events are triggered by the destination bucket. A review comment identifies a potential resource leak because the file cleanup logic is not scoped to cover processing failures, and it points out that fs.unlink is being incorrectly used as a promise-based function instead of fs.promises.unlink.
iennae
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes internal: b/503844690
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.