Skip to content

chore: update uuid to ^11.1.1 in third chunk of packages#4355

Merged
grayside merged 3 commits into
mainfrom
fix/uuid-update-chunk-3
Jun 22, 2026
Merged

chore: update uuid to ^11.1.1 in third chunk of packages#4355
grayside merged 3 commits into
mainfrom
fix/uuid-update-chunk-3

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b/508686791

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: cloudfunctions Issues related to the Cloud Run functions API. api: documentai Issues related to the Document AI API. api: eventarc Issues related to the Eventarc API. api: genai asset: pattern DEE Asset tagging - Pattern. labels Jun 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the uuid dependency from ^10.0.0 to ^11.1.1 across multiple package.json files. The review feedback correctly identifies compatibility issues in eventarc/generic/package.json and document-ai/package.json, where the new uuid version (which requires Node.js >= 18) conflicts with the older Node.js engine requirements specified in those packages. It is recommended to either revert the dependency upgrade or update the Node.js engine requirements accordingly.

Comment thread eventarc/generic/package.json
Comment thread document-ai/package.json
@angelcaamal angelcaamal marked this pull request as ready for review June 22, 2026 18:26
@angelcaamal angelcaamal requested review from a team as code owners June 22, 2026 18:26
@angelcaamal angelcaamal requested a review from grayside June 22, 2026 20:45
@grayside grayside merged commit 1b69b53 into main Jun 22, 2026
32 of 34 checks passed
@grayside grayside deleted the fix/uuid-update-chunk-3 branch June 22, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. api: documentai Issues related to the Document AI API. api: eventarc Issues related to the Eventarc API. api: genai asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants