Skip to content

add flask example and region tags#128

Merged
aabmass merged 3 commits intoGoogleCloudPlatform:masterfrom
aabmass:add-flask-and-region-tags
Apr 12, 2021
Merged

add flask example and region tags#128
aabmass merged 3 commits intoGoogleCloudPlatform:masterfrom
aabmass:add-flask-and-region-tags

Conversation

@aabmass
Copy link
Copy Markdown
Collaborator

@aabmass aabmass commented Apr 12, 2021

  • add region tags to advanced_trace.py
  • add flask e2e example with new region tags

@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 12, 2021

Here is the summary of possible violations 😱

Details

There are 9 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla Bot added the cla: yes label Apr 12, 2021
@aabmass aabmass force-pushed the add-flask-and-region-tags branch from 8c76438 to e9c3f10 Compare April 12, 2021 19:06
@aabmass
Copy link
Copy Markdown
Collaborator Author

aabmass commented Apr 12, 2021

Built docs for the new flask example from the CircleCI run: https://3200-244484614-gh.circle-artifacts.com/0/docs-html/examples/flask_e2e/README.html

@aabmass aabmass marked this pull request as ready for review April 12, 2021 19:09
@aabmass aabmass requested a review from a team April 12, 2021 19:09
@aabmass aabmass changed the title add flask and region tags add flask example and region tags Apr 12, 2021
@aabmass
Copy link
Copy Markdown
Collaborator Author

aabmass commented Apr 12, 2021

Here is the summary of possible violations 😱

There are 9 possible violations for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only.

This is flaky and OK to ignore right now. I verified there is a product prefix

@aabmass aabmass merged commit f8062b0 into GoogleCloudPlatform:master Apr 12, 2021
@aabmass aabmass deleted the add-flask-and-region-tags branch April 12, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants