Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

Conversation

@tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Apr 23, 2018

I'm copying over to the new directory. See the 2nd commit for the actual changes.

@tmatsuo tmatsuo requested a review from chingor13 April 23, 2018 22:38
WORKDIR /workspace

ENTRYPOINT ["/build.sh"]
COPY debian /workspace/debian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't /workspace mounted over during the cloud build process?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, removed in the next cl

cp ../*.deb ${ARTIFACT_LIB_DIR}
popd
fi
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra whitespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tmatsuo tmatsuo merged commit a41e47a into GoogleCloudPlatform:master Apr 24, 2018
frost-byte pushed a commit to Wiser-Owl/php-docker that referenced this pull request May 9, 2021
Build deb packages for ubuntu 16.04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants