Skip to content

chore(appengine): enable deployment tests for php74 #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

chore(appengine): enable deployment tests for php74 #1242

wants to merge 7 commits into from

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Dec 15, 2020

Addresses b/173545239

@ace-n ace-n requested review from bshaffer and engelke December 15, 2020 23:30
@product-auto-label product-auto-label bot added api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples. labels Dec 15, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
engelke
engelke approved these changes Dec 15, 2020
View reviewed changes
Copy link

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace-n
Copy link
Contributor Author

ace-n commented Dec 15, 2020 •
edited
Loading

The PHP 7 GAE samples are in a php72 directory.

Should we move them to a php74 directory, or just a php7 one? (The latter might reduce further docs moves.)

Also: cl/347708615 should unblock the tests internally.

@engelke
Copy link

engelke commented Dec 15, 2020

Assuming that PHP 7.4 samples would be very close to PHP 7.2 ones, then, yes, I would change the name of the php72 directory to php7 and update the sample to 7.4. That's what I did with the Python samples, which used to have a standard_python37 directory and now has only a standard_python3 one.

@ace-n
Copy link
Contributor Author

ace-n commented Dec 15, 2020

@engelke gotcha. If @bshaffer is on board, I can do that in this PR + take care of the docs impact.

@ace-n ace-n mentioned this pull request Dec 16, 2020
Closed
@ace-n ace-n marked this pull request as ready for review February 5, 2021 21:34
@ace-n ace-n requested a review from a team as a code owner February 5, 2021 21:34
@bshaffer bshaffer added the kokoro:run-all Runs all Kokoro tests for a PR label Feb 5, 2021
@bshaffer
Copy link
Contributor

bshaffer commented Feb 5, 2021

No tests were run by this PR, because it didn't have the kokoro:run-all label.

@ace-n ace-n mentioned this pull request Feb 11, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 11, 2021
chore(testing): add ability to skip GAE Flex tests (#1275)
5fdf2bb 
Related to b/173545239 and #1242
@ace-n
Copy link
Contributor Author

ace-n commented Feb 16, 2021

Looks like the following directories were missed in #1275; fixed in #1281.

appengine/flexible/supervisord/addition
appengine/flexible/supervisord/replacement

@ace-n ace-n mentioned this pull request Feb 17, 2021
Merged
@ace-n ace-n removed the kokoro:run-all Runs all Kokoro tests for a PR label Mar 30, 2021
@ace-n
Copy link
Contributor Author

ace-n commented Mar 30, 2021

This is quasi-blocked on us cleaning up the Kokoro architecture.

@ace-n ace-n mentioned this pull request May 25, 2021
Merged
@ace-n
Copy link
Contributor Author

ace-n commented May 25, 2021

This PR has been obviated by #1336 and #1365.

@ace-n ace-n closed this May 25, 2021
@ace-n ace-n deleted the php74 branch May 25, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer Awaiting requested review from bshaffer

1 more reviewer

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: appengine Issues related to the App Engine Admin API API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ace-n @engelke @bshaffer