Skip to content

feat: add deployment tests, remove unused scripts + GAE storage samples #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
May 19, 2021
Merged

feat: add deployment tests, remove unused scripts + GAE storage samples #1336

merged 46 commits into from
May 19, 2021

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Apr 5, 2021

No description provided.

@bshaffer bshaffer requested a review from ace-n April 5, 2021 23:20
@bshaffer bshaffer requested a review from a team as a code owner April 5, 2021 23:20
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2021
bshaffer
bshaffer commented Apr 5, 2021
View reviewed changes
testing/run_test_suite.sh
TESTCMD="$TESTCMD --group deploy"
else
TESTCMD="$TESTCMD --exclude-group deploy"
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New logic added so when RUN_DEPLOYMENT_TESTS is true, only the deploy group is run

@bshaffer bshaffer added the kokoro:run-all Runs all Kokoro tests for a PR label Apr 6, 2021
@ace-n
Copy link
Contributor

ace-n commented Apr 6, 2021

@bshaffer taking another go at this. (Feel free to add fixes on top of this one!)

@ace-n
Copy link
Contributor

ace-n commented Apr 7, 2021

This PR should fix [most of] the functions failures. Re-running tests now.

@ace-n ace-n added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2021
@bshaffer bshaffer force-pushed the add-deployment-tests branch from dccff91 to 36aae36 Compare April 7, 2021 20:38
@ace-n
Copy link
Contributor

ace-n commented Apr 9, 2021 •
edited
Loading

Some of the functions tests took quite awhile. (10 mins +)

@bshaffer I probably don't have time to continue working on this until next week, so would you mind reducing the retry limit on those? (If they haven't passed within ~5 minutes, they probably should fail outright.)

@snippet-bot
Copy link

snippet-bot bot commented Apr 29, 2021

Here is the summary of changes.

You are about to delete 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ace-n ace-n changed the title feat: add deployment tests, remove unused scripts feat: add deployment tests, remove unused scripts + GAE storage samples Apr 29, 2021
@ace-n ace-n mentioned this pull request May 3, 2021
Open
@ace-n ace-n added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 7, 2021
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 7, 2021
@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2021
@ace-n
Copy link
Contributor

ace-n commented May 19, 2021

@bshaffer looks like deployment tests are passing! 🎉

Would you mind fixing the unit tests though?

@bshaffer bshaffer merged commit c594414 into master May 19, 2021
@bshaffer bshaffer deleted the add-deployment-tests branch May 19, 2021 18:32
@bshaffer
Copy link
Contributor Author

@ace-n the same tests have failed the last two nights in our nightly builds so I won't block this PR on them.

Nice work!!

This was referenced May 25, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ace-n ace-n ace-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. kokoro:run-all Runs all Kokoro tests for a PR samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bshaffer @ace-n @kokoro-team