Conversation
product-auto-label
Bot
added
the
samples
google-cla
Bot
added
the
cla: yes
| # Serverless samples | ||
| /appengine/standard @engelke @GoogleCloudPlatform/cdpe-serverless | ||
| /functions @ace-n @grant @GoogleCloudPlatform/cdpe-serverless | ||
| /run @grayside @GoogleCloudPlatform/cdpe-cbr-containers |
There was a problem hiding this comment.
run should have the same ownership as the other serverless products. I will double check and decommission cdpe-cbr-containers.
There was a problem hiding this comment.
Thanks.
Should we remove the specific-person assignments here too, since we're trying to better distribute workloads within the team? (OTOH, a single point-of-contact can help ensure timely responses and prevent a "tragedy of the commons".)
cc @iennae
There was a problem hiding this comment.
I agree with this, seems like we should remove personal github handles.
Mine is included, but that is because it's an exception, and the samples are removed if I ever stop maintaining them 😃
| /run @grayside @GoogleCloudPlatform/cdpe-cbr-containers | ||
|
|
||
| # Functions samples owned by the Firebase team | ||
| /functions/firebase_analytics @schandel @samtstern |
There was a problem hiding this comment.
Is there a firebase team that should be used here? Shouldn't they be reviewers of this PR?
There was a problem hiding this comment.
cc @schandel @samtstern (I don't think they're members of the GoogleCloudPlatform GitHub org, so I can't add them as reviewers)
There was a problem hiding this comment.
If they're not in the org, how can they be CODEOWNERS?
|
@grayside ping? 🙂 |
Co-authored-by: Adam Ross <adamross@google.com>
|
replaced by #1708 |
4 participants
Let's (more) clearly denote who owns what
cc @iennae