Skip to content

Chore(Spanner): Add return types and signature arguments for samples.#1702

Merged
vishwarajanand merged 3 commits intomasterfrom
new_function_sign2
Oct 4, 2022
Merged

Chore(Spanner): Add return types and signature arguments for samples.#1702
vishwarajanand merged 3 commits intomasterfrom
new_function_sign2

Conversation

@ajupazhamayil
Copy link
Copy Markdown
Contributor

@ajupazhamayil ajupazhamayil commented Oct 3, 2022

This PR add return types and signature arguments for spanner samples.

@ajupazhamayil ajupazhamayil requested a review from a team as a code owner October 3, 2022 07:25
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Oct 3, 2022
@ajupazhamayil ajupazhamayil force-pushed the new_function_sign2 branch 2 times, most recently from efe3330 to 7f05273 Compare October 3, 2022 07:51
@ajupazhamayil
Copy link
Copy Markdown
Contributor Author

ajupazhamayil commented Oct 3, 2022 •
edited
Loading

Following files has no change since they are already in the new signature (20/98 files):

old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_connect_to_db.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_functions.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/create_instance_with_processing_units.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_partitioned_dml.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_interleaved_table.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_case_sensitivity.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_cast_data_type.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/list_backup_operations.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/set_request_tag.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_dml_with_params.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_order_nulls.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_information_schema.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_dml_getting_started_update.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_batch_dml.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_numeric_data_type.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_create_storing_index.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_add_column.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/set_transaction_tag.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_query_parameter.php
old_signature equal to new_signature for file /Users/ajumalpa/repos/php-docs-samples/spanner/src/pg_create_database.php

@ajupazhamayil
Copy link
Copy Markdown
Contributor Author

ajupazhamayil commented Oct 3, 2022

The script we have used it to complete this task is available here in the following repository: https://github.com/ajupazhamayil/function_signature_adder

@vishwarajanand
Copy link
Copy Markdown
Contributor

vishwarajanand commented Oct 3, 2022

LGTM.
Also the linked repo is nice for further extension if we want to take up similar work in future.

@vishwarajanand
Copy link
Copy Markdown
Contributor

vishwarajanand commented Oct 3, 2022

Had an internal discussion, we are good with this change (without freezing) since there's no filepath change.

vishwarajanand
vishwarajanand approved these changes Oct 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had an internal discussion, it seems we are good with this change (without freezing) since there's no filepath change.
@ajupazhamayil Pls address this issue too: ajupazhamayil/function_signature_adder#1

@ajupazhamayil
Copy link
Copy Markdown
Contributor Author

ajupazhamayil commented Oct 3, 2022

@vishwarajanand The issue has been addressed, Thank you!

@ajupazhamayil ajupazhamayil linked an issue Oct 4, 2022 that may be closed by this pull request
Spanner: Add return types and signature arguments for spanner samples. #1698
Closed
@vishwarajanand vishwarajanand merged commit 5c4fd35 into master Oct 4, 2022
@vishwarajanand vishwarajanand deleted the new_function_sign2 branch October 4, 2022 09:33
@ajupazhamayil ajupazhamayil changed the title Add return types and signature arguments for spanner samples. Chore(Spanner): Add return types and signature arguments for samples. Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saranshdhingra saranshdhingra Awaiting requested review from saranshdhingra

1 more reviewer

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spanner: Add return types and signature arguments for spanner samples.

2 participants

@ajupazhamayil @vishwarajanand