[E2E refactor - 3] re-introduce generated clientsets to prepare for simpler e2e tests#745
Merged
Conversation
pintohutch
force-pushed
the
pintohutch/e2e-2
branch
2 times, most recently
from
fbc5a52 to
ac4ffee
Compare
pintohutch
force-pushed
the
pintohutch/e2e-3
branch
from
70a794b to
2f0dc1f
Compare
pintohutch
force-pushed
the
pintohutch/e2e-2
branch
from
ac4ffee to
4643252
Compare
Collaborator
Author
|
Thanks! Waiting on @TheSpiritXIII's review on #744 and once that looks good, i'll merge this as well 👍 |
pintohutch
force-pushed
the
pintohutch/e2e-3
branch
2 times, most recently
from
b32ffa4 to
2f0dc1f
Compare
pintohutch
force-pushed
the
pintohutch/e2e-2
branch
from
5b8fe69 to
3433c63
Compare
pintohutch
force-pushed
the
pintohutch/e2e-3
branch
from
2f0dc1f to
8ae42f8
Compare
Also fix regeneration of clientsets to be idempotent
also add tls insecure skip verify flag to kubeletscraping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to break out the kind E2E test refactor PR #738 into smaller, digestible PRs for reviewing.
Note: because of the nature of the change, presubmits (i.e. Github Actions) may fail until the final PR is merged.
This is the third one, where we reintroduced generating k8s clientsets of our CRD types. This sets us up to ensure e2e tests don't require controller-runtime, which can be beneficial when importing the library elsewhere. This is an effective revert of c5eeee3.