[E2E refactor - 5] refactor ruler e2e tests#747
Merged
Conversation
pintohutch
force-pushed
the
pintohutch/e2e-4
branch
from
f5131f1 to
006996e
Compare
pintohutch
force-pushed
the
pintohutch/e2e-5
branch
from
b7fb05d to
cd759a0
Compare
pintohutch
force-pushed
the
pintohutch/e2e-4
branch
from
006996e to
54d92f1
Compare
pintohutch
force-pushed
the
pintohutch/e2e-5
branch
from
cd759a0 to
65a2985
Compare
pintohutch
force-pushed
the
pintohutch/e2e-4
branch
from
54d92f1 to
6243343
Compare
pintohutch
force-pushed
the
pintohutch/e2e-5
branch
from
65a2985 to
2b2e05c
Compare
bwplotka
approved these changes
Feb 1, 2024
Collaborator
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Nice, LGTM mod some suggestions
pintohutch
force-pushed
the
pintohutch/e2e-4
branch
2 times, most recently
from
3ce62f8 to
9f7ebbe
Compare
pintohutch
force-pushed
the
pintohutch/e2e-5
branch
from
2b2e05c to
b8885dd
Compare
also add tls insecure skip verify flag to kubeletscraping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to break out the kind E2E test refactor PR #738 into smaller, digestible PRs for reviewing.
Note: because of the nature of the change, presubmits (i.e. Github Actions) may fail until the final PR is merged.
This is the fifth one, where we refactor and simplify rule-evaluator e2e tests.