Skip to content

chore: Update OpenTelemetry semantic conventions to v1.39.0#295

Merged
ridwanmsharif merged 1 commit intorelease-2.53.5-gmpfrom
fix/tracing-semconv
Mar 24, 2026
Merged

chore: Update OpenTelemetry semantic conventions to v1.39.0#295
ridwanmsharif merged 1 commit intorelease-2.53.5-gmpfrom
fix/tracing-semconv

Conversation

@ridwanmsharif
Copy link
Copy Markdown
Collaborator

Fixes some of the broken CI tests

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the OpenTelemetry semantic conventions to a newer version, specifically v1.40.0. This update is intended to address and fix some existing broken CI tests, ensuring the continuous integration pipeline functions correctly with the latest conventions.

Highlights

  • Dependency Update: The OpenTelemetry semantic conventions dependency has been updated from v1.26.0 to v1.40.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenTelemetry semantic conventions import path to version v1.40.0. This change aligns the semconv package version with the rest of the OpenTelemetry dependencies, which are also at v1.40.0 as reflected in the go.mod file. This is a correct and necessary update for dependency consistency. The change looks good and I have no further comments.

@ridwanmsharif ridwanmsharif force-pushed the fix/tracing-semconv branch 3 times, most recently from 1c37b1f to 3ac077f Compare March 19, 2026 20:59
Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
@ridwanmsharif ridwanmsharif changed the title chore: Update OpenTelemetry semantic conventions to v1.40.0 chore: Update OpenTelemetry semantic conventions to v1.39.0 Mar 19, 2026
@ridwanmsharif
Copy link
Copy Markdown
Collaborator Author

Should be a safe change, only attrs we care about are:

res, err := resource.New(
ctx,
resource.WithSchemaURL(semconv.SchemaURL),
resource.WithAttributes(
semconv.ServiceNameKey.String(serviceName),
semconv.ServiceVersionKey.String(version.Version),
),
and they haven't changed in the new versions

Copy link
Copy Markdown
Collaborator

@bernot-dev bernot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ridwanmsharif ridwanmsharif merged commit 81a3117 into release-2.53.5-gmp Mar 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants