Skip to content

Conversation

@Valeriy-Burlaka
Copy link
Contributor

@Valeriy-Burlaka Valeriy-Burlaka commented Sep 25, 2024

Description

Adds a new sample for the "Update the context cache using its expire_time parameter" section of the context-cache/context-cache-update Vertex AI page.

Checklist

  • I have followed Sample Guidelines from AUTHORING_GUIDE.MD
  • README is updated to include all relevant information
  • Tests pass: nox -s py-3.8 and nox -s py-3.11
  • Lint pass: nox -s lint
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@Valeriy-Burlaka Valeriy-Burlaka requested review from a team as code owners September 25, 2024 13:28
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 25, 2024
@snippet-bot
Copy link

snippet-bot bot commented Sep 25, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Valeriy-Burlaka

This comment was marked as outdated.

* Update 'TODO' line to follow the runnable-snippets-plan standard.
@Valeriy-Burlaka Valeriy-Burlaka changed the title Add a sample for updating context cache with an expiration date feat: (Gen AI): Add a sample for updating context cache with an expiration date Sep 26, 2024
@msampathkumar msampathkumar self-assigned this Oct 1, 2024
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR looks good. Need minor changes.

@msampathkumar msampathkumar added the waiting-response Waiting for the author's response. label Oct 3, 2024
Valeriy-Burlaka and others added 2 commits October 3, 2024 15:01
Co-authored-by: Sampath Kumar <sam1990kumar@gmail.com>
Co-authored-by: Sampath Kumar <sam1990kumar@gmail.com>
@Valeriy-Burlaka Valeriy-Burlaka removed the waiting-response Waiting for the author's response. label Oct 3, 2024
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work @Valeriy-Burlaka

@msampathkumar msampathkumar merged commit 48f5cc7 into GoogleCloudPlatform:main Oct 3, 2024
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
… info (GoogleCloudPlatform#12631)

Update an existing code sample to shared details to using `expiration date` option


Co-authored-by: Sampath Kumar <sam1990kumar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants