Skip to content

Conversation

@glasnt
Copy link
Contributor

@glasnt glasnt commented Jan 7, 2025

Description

Replaces #12930

Updates google-crc32c dependency, and updates minimum Python version tested from 3.8 (support dropped in google-crc32c 1.6.0) to Python 3.9

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@glasnt glasnt requested review from a team as code owners January 7, 2025 00:49
@ghost
Copy link

ghost commented Jan 7, 2025

Gemini encountered an error creating the summary. You can try again by commenting @code-review-assist summarize.

3 similar comments
@ghost
Copy link

ghost commented Jan 7, 2025

Gemini encountered an error creating the summary. You can try again by commenting @code-review-assist summarize.

@ghost
Copy link

ghost commented Jan 7, 2025

Gemini encountered an error creating the summary. You can try again by commenting @code-review-assist summarize.

@ghost
Copy link

ghost commented Jan 7, 2025

Gemini encountered an error creating the summary. You can try again by commenting @code-review-assist summarize.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 7, 2025
@ghost
Copy link

ghost commented Jan 7, 2025

Gemini encountered an error creating the summary. You can try again by commenting @code-review-assist summarize.

@product-auto-label product-auto-label bot added the api: secretmanager Issues related to the Secret Manager API. label Jan 7, 2025
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing. LGTM.

@msampathkumar msampathkumar merged commit d618a0c into main Jan 14, 2025
13 checks passed
@msampathkumar msampathkumar deleted the sm-crc branch January 14, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants