-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore(gae): delete (archive) samples in standard folder: mail & sendgrid #13207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gae): delete (archive) samples in standard folder: mail & sendgrid #13207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @eapl-gemugami, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request removes unused samples related to mail and SendGrid from the Google App Engine standard environment documentation. The deleted files include the code, tests, and configurations for handling email attachments, bounced emails, incoming emails, email headers, and sending emails using both the App Engine mail service and SendGrid. The goal is to clean up the repository by removing outdated or irrelevant examples, as indicated by the internal issue tracker.
Highlights
- Removal of Mail Samples: The pull request removes the complete mail sample application, including the
README.md,app.yaml, python scripts for various mail functionalities (sending, receiving, attachments, bounces, headers), associated tests, and requirements files. - Removal of SendGrid Samples: The pull request removes the complete SendGrid sample application, including the
README.md,app.yaml,appengine_config.py, python scripts for sending emails via SendGrid, associated tests, and requirements files. - Internal Issue Fix: This change addresses and resolves multiple internal issues related to unused mail and sendgrid samples.
Changelog
Click here to see the changelog
- appengine/standard/mail/README.md
- Removed the entire
README.mdfile for the mail sample.
- Removed the entire
- appengine/standard/mail/app.yaml
- Removed the entire
app.yamlfile for the mail sample.
- Removed the entire
- appengine/standard/mail/attachment.py
- Removed the entire
attachment.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/attachment_test.py
- Removed the entire
attachment_test.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/handle_bounced_email.py
- Removed the entire
handle_bounced_email.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/handle_bounced_email_test.py
- Removed the entire
handle_bounced_email_test.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/handle_incoming_email.py
- Removed the entire
handle_incoming_email.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/handle_incoming_email_test.py
- Removed the entire
handle_incoming_email_test.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/header.py
- Removed the entire
header.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/header_test.py
- Removed the entire
header_test.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/index.html
- Removed the entire
index.htmlfile for the mail sample.
- Removed the entire
- appengine/standard/mail/requirements-test.txt
- Removed the entire
requirements-test.txtfile for the mail sample.
- Removed the entire
- appengine/standard/mail/requirements.txt
- Removed the entire
requirements.txtfile for the mail sample.
- Removed the entire
- appengine/standard/mail/send_mail.py
- Removed the entire
send_mail.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/send_mail_test.py
- Removed the entire
send_mail_test.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/send_message.py
- Removed the entire
send_message.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/send_message_test.py
- Removed the entire
send_message_test.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/user_signup.py
- Removed the entire
user_signup.pyfile for the mail sample.
- Removed the entire
- appengine/standard/mail/user_signup_test.py
- Removed the entire
user_signup_test.pyfile for the mail sample.
- Removed the entire
- appengine/standard/sendgrid/README.md
- Removed the entire
README.mdfile for the sendgrid sample.
- Removed the entire
- appengine/standard/sendgrid/app.yaml
- Removed the entire
app.yamlfile for the sendgrid sample.
- Removed the entire
- appengine/standard/sendgrid/appengine_config.py
- Removed the entire
appengine_config.pyfile for the sendgrid sample.
- Removed the entire
- appengine/standard/sendgrid/main.py
- Removed the entire
main.pyfile for the sendgrid sample.
- Removed the entire
- appengine/standard/sendgrid/main_test.py
- Removed the entire
main_test.pyfile for the sendgrid sample.
- Removed the entire
- appengine/standard/sendgrid/requirements-test.txt
- Removed the entire
requirements-test.txtfile for the sendgrid sample.
- Removed the entire
- appengine/standard/sendgrid/requirements.txt
- Removed the entire
requirements.txtfile for the sendgrid sample.
- Removed the entire
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the primary use case for YAML files, as seen in the deleted app.yaml files?
Click here for the answer
YAML files are primarily used for configuration settings in applications. In the context of Google App Engine, `app.yaml` defines the runtime environment, handlers, and other settings for deploying an application.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Here is the summary of changes. You are about to delete 16 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request focuses on removing unused samples related to mail and SendGrid in the Google App Engine standard environment. The changes involve deleting entire files and directories, which simplifies the repository by removing outdated or irrelevant code. The pull request description includes references to internal bug tracking issues, indicating that these removals are intentional and address specific internal concerns.
Summary of Findings
- Removal of samples: This pull request removes several samples related to mail and SendGrid functionality in the Google App Engine standard environment. Ensure that the removal of these samples does not negatively impact existing documentation or user workflows that rely on them.
Merge Readiness
The pull request removes unused samples, which should simplify the repository. Given the nature of the changes (deletions), it's crucial to verify that no external documentation or user workflows depend on these samples. Since I am unable to approve the pull request, please ensure others review and approve this code before merging.
Description
Fixes internal:
b/347350540
send_attachment
b/347350719
sendgrid-config
b/347350950
sendgrid-imp
b/347350541
sendgrid-send
Checklist