Skip to content

docs(generative_ai): Update Dynamic Retrieval for Grounding to include Mode#13208

Merged
holtskinner merged 1 commit intomainfrom
grounding-dyn-retrieval
Mar 7, 2025
Merged

docs(generative_ai): Update Dynamic Retrieval for Grounding to include Mode#13208
holtskinner merged 1 commit intomainfrom
grounding-dyn-retrieval

Conversation

@holtskinner
Copy link
Copy Markdown
Contributor

No description provided.

@holtskinner holtskinner requested review from a team as code owners March 5, 2025 18:12
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Mar 5, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the documentation and an example related to dynamic retrieval for grounding in the generative AI models. Specifically, it updates the google-cloud-aiplatform dependency to version 1.82.0 and adds the mode parameter to the DynamicRetrievalConfig in the web_example.py file. It also changes print(response.text) to print(response) in the same file.

Highlights

  • Dependency Update: The google-cloud-aiplatform dependency has been updated from version 1.78.0 to 1.82.0 in requirements.txt.
  • Dynamic Retrieval Configuration: The mode parameter has been added to the DynamicRetrievalConfig in web_example.py, explicitly setting the mode to MODE_DYNAMIC.
  • Output Modification: The output in web_example.py has been changed from printing response.text to printing the entire response object.

Changelog

  • generative_ai/grounding/requirements.txt
    • Updated google-cloud-aiplatform dependency from version 1.78.0 to 1.82.0.
  • generative_ai/grounding/web_example.py
    • Added the mode parameter to DynamicRetrievalConfig, setting it to MODE_DYNAMIC.
    • Changed the output from print(response.text) to print(response).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Trivia time!

What is the primary function of the Google Cloud AI Platform?

Click here for the answer
The primary function of Google Cloud AI Platform is to provide a suite of services to build, deploy, and manage machine learning models in the cloud.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the google-cloud-aiplatform dependency and introduces the mode parameter for dynamic retrieval configuration in the web_example.py file. It also changes the print statement to output the entire response object instead of just the text. Overall, the changes seem reasonable, but let's take a closer look.

Summary of Findings

  • Dependency Update: The google-cloud-aiplatform dependency is updated from 1.78.0 to 1.82.0. Ensure that this update is compatible with the rest of the codebase and that all necessary tests pass.
  • Dynamic Retrieval Mode: The mode parameter is added to the DynamicRetrievalConfig with the value grounding.DynamicRetrievalConfig.Mode.MODE_DYNAMIC. Verify that this is the intended default behavior and that other modes are also handled correctly if applicable.
  • Print Statement Change: The print(response.text) statement is changed to print(response). This will output the entire response object, which may contain more information than just the text. Consider whether this is the desired behavior and if it might expose sensitive information.

Merge Readiness

The pull request seems to be on the right track, but there are a few points to consider before merging. The dependency update should be verified for compatibility, the dynamic retrieval mode should be confirmed as the intended default, and the change in the print statement should be carefully evaluated. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

Comment thread generative_ai/grounding/web_example.py
Comment thread generative_ai/grounding/web_example.py
@holtskinner holtskinner assigned msampathkumar and unassigned nicain Mar 5, 2025
Copy link
Copy Markdown
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No major changes.

@holtskinner holtskinner merged commit 6c8b9a1 into main Mar 7, 2025
@holtskinner holtskinner deleted the grounding-dyn-retrieval branch March 7, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants