-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore(deps): update dependency kubernetes to v34 #13580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency kubernetes to v34 #13580
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the kubernetes Python client from version 33.1.0 to 34.1.0. While keeping dependencies current is important, this major version bump aligns the client with Kubernetes API version 1.34. This creates a significant version skew with the GKE clusters used in the integration tests, which are created with a default version that is likely much older. This incompatibility is likely to cause test failures. My review comment highlights this risk and suggests updating the test environment to ensure compatibility.
| google-cloud-gke-connect-gateway==0.10.4 | ||
| google-auth==2.38.0 | ||
| kubernetes==33.1.0 | ||
| kubernetes==34.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to kubernetes client v34.1.0 targets Kubernetes API v1.34. The integration tests in get_namespace_test.py create a GKE cluster with a default version, which may be significantly older (e.g., v1.28 or v1.29). This large client/server version skew is unsupported (the Kubernetes API officially supports a skew of +/- 1 minor version) and will likely cause the tests to fail.
To fix this, the test setup in get_namespace_test.py should be updated to explicitly create a GKE cluster with a Kubernetes version compatible with this client, for example by setting initial_cluster_version to a 1.34.x version.
This PR contains the following updates:
==33.1.0->==34.1.0Release Notes
kubernetes-client/python (kubernetes)
v34.1.0Compare Source
Kubernetes API Version: v1.34.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.