Skip to content

chore: fix detect logos snippets#13733

Merged
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
Alan5142:main
Jan 10, 2026
Merged

chore: fix detect logos snippets#13733
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
Alan5142:main

Conversation

@Alan5142
Copy link
Copy Markdown
Contributor

@Alan5142 Alan5142 commented Jan 9, 2026

Description

Fix the detection logos snippets to use annotate_image instead of logo_detection

Checklist

@Alan5142 Alan5142 requested review from a team as code owners January 9, 2026 18:09
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: vision Issues related to the Cloud Vision API. labels Jan 9, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Alan5142, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the logo detection snippets within the Google Cloud Vision API samples. It transitions from using the specific logo_detection client method to the more versatile annotate_image method, explicitly defining LOGO_DETECTION as a feature in the request. This change aligns the samples with current API best practices, ensuring robustness and future compatibility.

Highlights

  • API Method Update: The detect_logos function has been updated to use client.annotate_image with a LOGO_DETECTION feature, replacing the direct call to client.logo_detection.
  • URI-based Logo Detection: Similarly, the detect_logos_uri function now utilizes client.annotate_image with the LOGO_DETECTION feature for URI-based image processing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the logo detection snippets to use the annotate_image method, which is a good improvement. However, the new implementation constructs the request using a dictionary with a potentially incorrect key (type instead of type_), which could lead to bugs. My review includes suggestions to fix this by using a more idiomatic and robust approach, passing keyword arguments directly to the annotate_image method and explicitly creating vision.Feature objects. This will improve code clarity and correctness.

Comment thread vision/snippets/detect/detect.py
Comment thread vision/snippets/detect/detect.py
@iennae iennae merged commit e55d3a7 into GoogleCloudPlatform:main Jan 10, 2026
11 checks passed
glasnt pushed a commit that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vision Issues related to the Cloud Vision API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants