Skip to content

Chore(logging) Removal of invalid samples and region tags#13895

Merged
iennae merged 2 commits intoGoogleCloudPlatform:mainfrom
XrossFox:delete-invalid-samples
Mar 6, 2026
Merged

Chore(logging) Removal of invalid samples and region tags#13895
iennae merged 2 commits intoGoogleCloudPlatform:mainfrom
XrossFox:delete-invalid-samples

Conversation

@XrossFox
Copy link
Copy Markdown
Contributor

@XrossFox XrossFox commented Mar 6, 2026

Removed invalid and unused samples for Logging.

Description

Fixes b/486227523

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@XrossFox XrossFox requested review from a team as code owners March 6, 2026 20:56
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Mar 6, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code hygiene by removing outdated and unused sample code related to Google Cloud Logging. This cleanup helps streamline the codebase, reduce maintenance overhead, and ensure that only relevant and functional examples are present.

Highlights

  • Sample Code Removal: Removed invalid and unused sample code for Google Cloud Logging, specifically the usage_guide_test.py file.
Changelog
  • logging/samples/snippets/usage_guide_test.py
    • Removed the entire test file for invalid and unused logging samples.
Activity
  • No review activity or comments have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Mar 6, 2026

Here is the summary of changes.

You are about to delete 42 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The original review included a comment that suggested combining the removal of tests and sample code into a single pull request. This recommendation contradicts the rule stating that it is acceptable to defer related changes to subsequent pull requests to simplify the review process. As a result, this comment has been dropped, and no specific code review comments are being provided.

@iennae iennae merged commit de18a99 into GoogleCloudPlatform:main Mar 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants