Skip to content

chore(multiple samples): update requests dependency across all samples#14202

Merged
iennae merged 4 commits into
GoogleCloudPlatform:mainfrom
XrossFox:python-requests-dependency-update-1
Jun 3, 2026
Merged

chore(multiple samples): update requests dependency across all samples#14202
iennae merged 4 commits into
GoogleCloudPlatform:mainfrom
XrossFox:python-requests-dependency-update-1

Conversation

@XrossFox
Copy link
Copy Markdown
Contributor

@XrossFox XrossFox commented May 20, 2026

  • Update requests to version 2.34.2
  • Pin requests to python 3.10 and newer

Fixes b/515152945

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. api: auth Issues related to the Google Authentication API api: bigquery Issues related to the BigQuery API. labels May 20, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the requests library to version 2.34.2 across numerous requirements.txt files and introduces a Python version constraint of >= 3.10. Review feedback highlights that the absence of fallback entries for Python versions older than 3.10 will cause runtime errors in those environments. Additionally, the [security] extra is noted as deprecated and should be removed, and one file is identified as autogenerated, requiring updates to be made to the source configuration rather than the compiled file.

Comment thread aml-ai/requirements.txt
Comment thread appengine/flexible/analytics/requirements.txt Outdated
Comment thread dataflow/flex-templates/pipeline_with_dependencies/requirements.txt Outdated
@XrossFox XrossFox force-pushed the python-requests-dependency-update-1 branch 2 times, most recently from aea3b43 to d582869 Compare June 3, 2026 21:30
@XrossFox XrossFox changed the title chore(multiple samples) Updating all instances of requests dependency. chore(multiple samples): update requests dependency across all samples Jun 3, 2026
Copy link
Copy Markdown

@Kef131 Kef131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XrossFox XrossFox marked this pull request as ready for review June 3, 2026 21:49
@XrossFox XrossFox requested review from a team, chalmerlowe and yuriatgoogle as code owners June 3, 2026 21:49
Comment thread dataflow/flex-templates/pipeline_with_dependencies/pyproject.toml
Comment thread kubernetes_engine/django_tutorial/requirements.txt Outdated
Copy link
Copy Markdown
Contributor

@amcolin amcolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

XrossFox added 3 commits June 3, 2026 23:03
 - Update requests to version 2.34.2
 - Pin requests to python 3.10 and newer
Updated toml file to reflect docker file.
@XrossFox XrossFox force-pushed the python-requests-dependency-update-1 branch from e13196d to b9c0c97 Compare June 3, 2026 23:04
@iennae iennae merged commit e177505 into GoogleCloudPlatform:main Jun 3, 2026
9 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. api: auth Issues related to the Google Authentication API api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants