Skip to content

chore(several samples) Updating all instances of Pytest up to version 9.0.3 Part III#14233

Merged
iennae merged 4 commits into
GoogleCloudPlatform:mainfrom
XrossFox:python-pytest-dependency-update-IV
May 27, 2026
Merged

chore(several samples) Updating all instances of Pytest up to version 9.0.3 Part III#14233
iennae merged 4 commits into
GoogleCloudPlatform:mainfrom
XrossFox:python-pytest-dependency-update-IV

Conversation

@XrossFox
Copy link
Copy Markdown
Contributor

@XrossFox XrossFox commented May 26, 2026

Directories that start from E to M.

  • Bump pytest to 9.0.3 (pinned to Python >= 3.10)
  • Update noxfile configs to only test against Python 3.10 and 3.14
  • Upgrade Dockerfile base images and Beam SDKs to Python 3.14 (Note, previously missed directories were modified too)

Description

Fixes b/516829625

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

…trix for a-m samples

 - Bump pytest to 9.0.3 (pinned to Python >= 3.10)
 - Update noxfile configs to only test against Python 3.10 and 3.14
 - Upgrade Dockerfile base images and Beam SDKs to Python 3.14
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. api: auth Issues related to the Google Authentication API api: cloudsql api: composer Issues related to the Cloud Composer API. labels May 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Python version to 3.14 across multiple Dockerfiles, updates test configurations in noxfile_config.py to ignore older Python versions, and bumps pytest dependencies. The review feedback highlights several critical issues where Python versions are mismatched within the Dockerfiles (such as conda environments or explicit Python installations still using 3.9 or 3.10 while copying the 3.14 Beam SDK). Additionally, several comments point out outdated inline documentation in the modified noxfile_config.py files that still reference older Python versions.

Comment thread dataflow/custom-containers/miniconda/Dockerfile
Comment thread dataflow/gpu-examples/tensorflow-landsat-prime/Dockerfile
Comment thread dataflow/gpu-examples/tensorflow-landsat/Dockerfile
Comment thread dataflow/gpu-examples/tensorflow-minimal/Dockerfile
Comment thread dataflow/snippets/Dockerfile
Comment thread dataflow/gpu-examples/tensorflow-landsat-prime/noxfile_config.py Outdated
Comment thread dataflow/gpu-examples/tensorflow-landsat/noxfile_config.py Outdated
Comment thread dataflow/gpu-examples/tensorflow-minimal/noxfile_config.py Outdated
Comment thread dataflow/flex-templates/pipeline_with_dependencies/Dockerfile Outdated
Comment thread dataflow/gemma-flex-template/Dockerfile
@XrossFox XrossFox changed the title chore(several samples) Updating all instances of Pytest up to version 9.0.3 Part IV chore(several samples) Updating all instances of Pytest up to version 9.0.3 Part III May 26, 2026
@XrossFox XrossFox added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 27, 2026
@XrossFox
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to upgrade Python versions to 3.14, update Apache Beam to version 2.73.0 across multiple Dockerfiles, and update test requirements to use pytest 9.0.3. However, several critical issues were identified: Python 3.14 is currently an unstable pre-release without official stable Docker images, and Apache Beam version 2.73.0 does not exist, which will cause Docker build and pip installation failures. Additionally, a package incompatibility was found in the custom App Engine Dockerfile where python-pip (Python 2) is installed alongside Python 3. It is highly recommended to use stable Python (e.g., 3.11 or 3.12) and valid Apache Beam releases.

Comment thread dataflow/snippets/Dockerfile
Comment thread dataflow/custom-containers/miniconda/Dockerfile
Comment thread endpoints/getting-started/Dockerfile.custom Outdated
Comment thread appengine/flexible/tasks/Dockerfile
…python 2.7

runtime. Will be left to be investigated at a later date.
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 27, 2026
@XrossFox
Copy link
Copy Markdown
Contributor Author

XrossFox commented May 27, 2026

Code Review

This pull request attempts to upgrade Python versions to 3.14, update Apache Beam to version 2.73.0 across multiple Dockerfiles, and update test requirements to use pytest 9.0.3. However, several critical issues were identified: Python 3.14 is currently an unstable pre-release without official stable Docker images, and Apache Beam version 2.73.0 does not exist, which will cause Docker build and pip installation failures. Additionally, a package incompatibility was found in the custom App Engine Dockerfile where python-pip (Python 2) is installed alongside Python 3. It is highly recommended to use stable Python (e.g., 3.11 or 3.12) and valid Apache Beam releases.

Python 3.14 and Apache bean 2.73 have already been released and available on docker hub.

https://pypi.org/project/apache-beam/
https://hub.docker.com/_/python/tags?name=3.14
https://hub.docker.com/r/apache/beam_python3.14_sdk

@iennae iennae marked this pull request as ready for review May 27, 2026 23:39
@iennae iennae requested review from a team and yuriatgoogle as code owners May 27, 2026 23:39
@iennae iennae merged commit ced17ad into GoogleCloudPlatform:main May 27, 2026
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. api: auth Issues related to the Google Authentication API api: cloudsql api: composer Issues related to the Cloud Composer API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants