chore(several samples) Updating all instances of Pytest up to version 9.0.3 Part III#14233
Conversation
…trix for a-m samples - Bump pytest to 9.0.3 (pinned to Python >= 3.10) - Update noxfile configs to only test against Python 3.10 and 3.14 - Upgrade Dockerfile base images and Beam SDKs to Python 3.14
There was a problem hiding this comment.
Code Review
This pull request upgrades the Python version to 3.14 across multiple Dockerfiles, updates test configurations in noxfile_config.py to ignore older Python versions, and bumps pytest dependencies. The review feedback highlights several critical issues where Python versions are mismatched within the Dockerfiles (such as conda environments or explicit Python installations still using 3.9 or 3.10 while copying the 3.14 Beam SDK). Additionally, several comments point out outdated inline documentation in the modified noxfile_config.py files that still reference older Python versions.
work only on python 3.14, and removed outdated comments.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request attempts to upgrade Python versions to 3.14, update Apache Beam to version 2.73.0 across multiple Dockerfiles, and update test requirements to use pytest 9.0.3. However, several critical issues were identified: Python 3.14 is currently an unstable pre-release without official stable Docker images, and Apache Beam version 2.73.0 does not exist, which will cause Docker build and pip installation failures. Additionally, a package incompatibility was found in the custom App Engine Dockerfile where python-pip (Python 2) is installed alongside Python 3. It is highly recommended to use stable Python (e.g., 3.11 or 3.12) and valid Apache Beam releases.
…python 2.7 runtime. Will be left to be investigated at a later date.
Python 3.14 and Apache bean 2.73 have already been released and available on docker hub. https://pypi.org/project/apache-beam/ |
Directories that start from E to M.
Description
Fixes b/516829625
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)