Skip to content

fix: remove kokoro as required for running#14267

Merged
iennae merged 3 commits into
mainfrom
iennae-patch-2
Jun 3, 2026
Merged

fix: remove kokoro as required for running#14267
iennae merged 3 commits into
mainfrom
iennae-patch-2

Conversation

@iennae
Copy link
Copy Markdown
Contributor

@iennae iennae commented Jun 3, 2026

Description

  • removes broken kokoro testing and the defunct yoshi teams.
  • updates checklist to reflect changes in testing guidance and improve sample contributor experience

replaces #14263

@iennae iennae requested review from a team as code owners June 3, 2026 18:43
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jun 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository settings configuration in .github/sync-repo-settings.yaml by modifying the required status checks and removing several team permission rules. The review feedback suggests completely removing the commented-out Kokoro status checks rather than leaving them in the file to maintain a clean and maintainable configuration.

Comment thread .github/sync-repo-settings.yaml Outdated
Comment on lines +45 to +47
- "Lint"
# - "Kokoro CI - Python 3.9"
# - "Kokoro CI - Python 3.13"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of leaving the defunct Kokoro status checks commented out, they should be completely removed to keep the configuration file clean and maintainable.

    - "Lint"

@iennae iennae merged commit c0076a1 into main Jun 3, 2026
12 of 20 checks passed
@iennae iennae deleted the iennae-patch-2 branch June 3, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants