Conversation
product-auto-label
bot
added
the
samples
shubha-rajan
added
kokoro:force-run
m-strzelczyk
approved these changes
Feb 7, 2023
jackwotherspoon
requested changes
Feb 7, 2023
| f"/projects/{project}/instances/{instance}/connectSettings") | ||
|
|
||
| resp = requests.get(url, headers=headers) | ||
| print(resp.json()) |
Contributor
There was a problem hiding this comment.
We probably want to remove this print statement.
jackwotherspoon
approved these changes
Feb 7, 2023
shubha-rajan
added
automerge
kokoro-team
removed
the
kokoro:force-run
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* download server CA cert for tests * add note to connect_tcp * remove raise_for_status * debug print response * refresh invalid credential * linting * Update connection_test.py --------- Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Download and use the server CA cert in SQL server tests
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)