chore: remove unused host from URL in SQL Server samples#9157
Merged
jackwotherspoon merged 2 commits intomainfrom Feb 21, 2023
Merged
chore: remove unused host from URL in SQL Server samples#9157jackwotherspoon merged 2 commits intomainfrom
host from URL in SQL Server samples#9157jackwotherspoon merged 2 commits intomainfrom
Conversation
product-auto-label
bot
added
samples
enocom
approved these changes
Feb 21, 2023
dandhlee
approved these changes
Feb 21, 2023
Collaborator
dandhlee
left a comment
dandhlee
left a comment
There was a problem hiding this comment.
Will the users know how to use host param if required?
Contributor
Author
The users should never have the |
jackwotherspoon
changed the title
host param in URLhost from URL in SQL Server samples
jackwotherspoon
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In latest version of
sqlalchemy-pytdslibrary #9145, thehostparam has become optional in the SQLAlchemy engine URL, our samples previously had a dummy value oflocalhostset to fulfill the required host param. Now that it is optional, we can removelocalhostfrom the URL for simplicity and to avoid confusion.