Skip to content

Conversation

@leahecole
Copy link
Collaborator

@leahecole leahecole commented Mar 7, 2023

Description

Removes 3.6 and 3.7 from testing - gets us down to one version so we can use a proper constraints file and not end up in dependency hell related test failures

Fixes #9244
Fixes #9243
Fixes #9242
Fixes #9241
Fixes #9240
Fixes #9239
Fixes #9238
Fixes #9237

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@leahecole leahecole requested review from a team and rachael-ds as code owners March 7, 2023 16:52
@google-cla
Copy link

google-cla bot commented Mar 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: composer Issues related to the Cloud Composer API. labels Mar 7, 2023
@leahecole leahecole marked this pull request as draft March 7, 2023 16:53
@leahecole leahecole force-pushed the fix_airflow_1_tests branch from afb05c5 to 82836e8 Compare March 7, 2023 16:54
@leahecole leahecole marked this pull request as ready for review March 7, 2023 16:54
@leahecole
Copy link
Collaborator Author

the original CLA failure comment was from a GH alias I use in glinux for a different repo I work with. I amended the commit to be accurate!

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


TEST_CONFIG_OVERRIDE = {
# You can opt out from the test for specific Python versions.
# Skipping for Python 3.9 due to numpy compilation failure.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the comment on reasons for skipping 3.10 and 3.11

@nicain nicain merged commit c99c9c0 into main Mar 7, 2023
@nicain nicain deleted the fix_airflow_1_tests branch March 7, 2023 19:58
telpirion pushed a commit that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: composer Issues related to the Cloud Composer API. samples Issues that are directly related to samples.

Projects

None yet

5 participants