Add support for workload and experiment tagging#387
Merged
rfbgo merged 6 commits intoGoogleCloudPlatform:developfrom Feb 1, 2024
Merged
Add support for workload and experiment tagging#387rfbgo merged 6 commits intoGoogleCloudPlatform:developfrom
rfbgo merged 6 commits intoGoogleCloudPlatform:developfrom
Conversation
douglasjacobsen
added
documentation
douglasjacobsen
force-pushed
the
experiment_tags
branch
8 times, most recently
from
d9d22ed to
33bc2ec
Compare
This commit adds the ability for workload directives to define tags, which are then tracked in experiment instances. Additionally, a `tags` attribute is added to the YAML schema for experiments and workloads. This allows experiments to be tagged at a finter grain within a workspace. The workspace info command is also updated to provide more control over the information provided.
This command allows other pipline commands (such a `on` and `workspace setup`) to fitler the experiments they act on based on their tags.
douglasjacobsen
force-pushed
the
experiment_tags
branch
2 times, most recently
from
1ef9ec1 to
e26491f
Compare
rfbgo
requested changes
Feb 1, 2024
Collaborator
rfbgo
left a comment
rfbgo
left a comment
There was a problem hiding this comment.
One simple request, otherwise LGTM
I think in general this feature makes more sense to me when looking across workspaces (which isn't in yet), but that can always be added later
douglasjacobsen
force-pushed
the
experiment_tags
branch
from
b98888c to
3724d02
Compare
rfbgo
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge adds the ability for workloads (defined in either an
application.pyor in workspace configuration files) and experiments (via only workspace configuration files) to define their own tags.Tags are used for two things:
workspace infoandon).Testing and documentation is added for this feature as well.