Allow ramble to read from the config to specify shell inside scripts#412
Merged
douglasjacobsen merged 1 commit intoGoogleCloudPlatform:developfrom Feb 16, 2024
Merged
Conversation
douglasjacobsen
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoid ramble hard writing
/bin/shand instead uses the value ofconfig:shell. This can either besh/csh/fish/bat/pwshas defined by our inherited code fromspack:util:environmentIn the future we might want to help a user directly emit calls to
bashorzsh, which would be an easy alias in the env class.