Add support for variants, a when clause, and the default_args clause #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
added
enhancement
This commit ports Spack's when and default_args functions (which can be used as directives) into Ramble's language definitions.
This commit adds support to each object type for variant definitions. Famiies are also added to workflow managers and package manager to enable variant checks to be easier to define.
douglasjacobsen
force-pushed
the
when-clause
branch
from
34bdbea to
dff715e
Compare
douglasjacobsen
changed the title
This commit propagates the changes for the `software_spec` and `required_package` directories, as then `package_manager` argument is deprecated now. Families are also added for the package manager and workflow manager definitions.
douglasjacobsen
force-pushed
the
when-clause
branch
from
dff715e to
d1024c8
Compare
linsword13
reviewed
Apr 7, 2025
Member
linsword13
left a comment
linsword13
left a comment
There was a problem hiding this comment.
Exciting stuff! A couple nit comments for now ;)
linsword13
reviewed
Apr 8, 2025
linsword13
reviewed
Apr 8, 2025
douglasjacobsen
force-pushed
the
when-clause
branch
2 times, most recently
from
cc290f5 to
c4850b0
Compare
douglasjacobsen
force-pushed
the
when-clause
branch
from
c4850b0 to
6ee495f
Compare
linsword13
previously approved these changes
Apr 10, 2025
rfbgo
previously approved these changes
Apr 14, 2025
rfbgo
reviewed
Apr 14, 2025
var/ramble/repos/builtin.mock/applications/when-variants/application.py
Outdated
Show resolved
Hide resolved
linsword13
approved these changes
Apr 15, 2025
dapomeroy
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds support for variants and two new directives.
Variants can be defined within object definitions to give them default values and allow experiments to define them.
The two new directives that are added are
whenanddefault_args. These were backported from Spack's implementation, and allow default definitions for shared arguments to be passed through with blocks.